From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 55C29395B06C for ; Tue, 31 May 2022 16:04:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 55C29395B06C Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-357-hFPZ-2aRM-y4V0DUJJrASw-1; Tue, 31 May 2022 12:03:32 -0400 X-MC-Unique: hFPZ-2aRM-y4V0DUJJrASw-1 Received: by mail-wm1-f69.google.com with SMTP id bg7-20020a05600c3c8700b0039468585269so6240798wmb.3 for ; Tue, 31 May 2022 09:03:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=qhpLMu+1XdAiBVc/JDmbaAvffoIYy4YZZUIwOAnfln0=; b=2dLlNoC7xosb03CmPXHkujrZhnNokgYQci9jcX21t0hrDaCRl7EZrovleVQ7w6S+6t A/ry5u7BWm0J3Vgula+xLZ6Jo3ih61oWiVXWuz94+LPO/5BeEyjnFDy3W0hvlcF+tvJ9 8li1rUqfj1gH1RpYcWgJArICOytfK3uElJ9w9c6tWu+nfhygveiE8Z21l9lUtWudEze+ 1EmwjZLSSN5hlWwaaycN6DZkJRyEKkDKf4em5bkNXD17JTJTOURgKLLKLL55MeqWw64P Ad/GhM42ov3OmBk4YrmoemvmlVFCgXFc/dQ1l4IXR5rHm/g27P6l4aq3mq2jG1A7Y7QP 8/vw== X-Gm-Message-State: AOAM532jv1aa06QwaLjwKBAdBz/MYKXBl7s+J+gI7hq3yhi+q9TpfWZk 5AsLIwCq98p4WYOy1RfXIL9CJ8XfeLLZqQVyZTF//DdoDRj81spKOnlfzg59KqDZZQz/+nem1ad 9YEW9DthcxB319J3KIh2eaA== X-Received: by 2002:a5d:6d85:0:b0:20f:e96b:84de with SMTP id l5-20020a5d6d85000000b0020fe96b84demr33806105wrs.427.1654013008303; Tue, 31 May 2022 09:03:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5NAwX9/grXxIVwhVtwiNbs4zX3zDaoSBhKH/1g6YOYLN35WaFO/ImPxQckKtjfhKcBRoOBQ== X-Received: by 2002:a5d:6d85:0:b0:20f:e96b:84de with SMTP id l5-20020a5d6d85000000b0020fe96b84demr33806061wrs.427.1654013007832; Tue, 31 May 2022 09:03:27 -0700 (PDT) Received: from localhost (host109-152-215-36.range109-152.btcentralplus.com. [109.152.215.36]) by smtp.gmail.com with ESMTPSA id l5-20020a1c2505000000b0039763d41a48sm2569044wml.25.2022.05.31.09.03.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 May 2022 09:03:27 -0700 (PDT) From: Andrew Burgess To: Nils-Christian Kempke , gdb-patches@sourceware.org Cc: JiniSusan.George@amd.com Subject: Re: [PATCH v2 10/16] testsuite, fortran: Add '-debug-parameters all' when using ifx/ifort In-Reply-To: <20220531092423.2361679-5-nils-christian.kempke@intel.com> References: <20220531092423.2361679-1-nils-christian.kempke@intel.com> <20220531092423.2361679-5-nils-christian.kempke@intel.com> Date: Tue, 31 May 2022 17:03:25 +0100 Message-ID: <87r149d702.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2022 16:04:43 -0000 Nils-Christian Kempke via Gdb-patches writes: > In order for ifx and ifort to emit all debug entries, even for unused > parameters in modules we have to define the '-debug-parameters all' flag. > > This commit adds it to the ifx-*/ifort-* specific flags in gdb.exp. LGTM. Thanks, Andrew > --- > gdb/testsuite/lib/gdb.exp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 87f0a36fe7..402450152a 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -4473,6 +4473,8 @@ proc gdb_compile {source dest type options} { > # Place (and look for) Fortran `.mod` files in the output > # directory for this specific test. For Intel compilers the -J > # option is not supported so instead use the -module flag. > + # Additionally, Intel compilers need the -debug-parameters flag set to > + # emit debug info for all parameters in modules. > if { !$getting_compiler_info && [lsearch -exact $options f90] != -1 } { > # Fortran compile. > set mod_path [standard_output_file ""] > @@ -4481,6 +4483,7 @@ proc gdb_compile {source dest type options} { > } elseif { [test_compiler_info {ifort-*} f90] > || [test_compiler_info {ifx-*} f90] } { > lappend new_options "additional_flags=-module ${mod_path}" > + lappend new_options "additional_flags=-debug-parameters all" > } > } > > -- > 2.25.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928