From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.33]) by sourceware.org (Postfix) with ESMTPS id A268C393BC1F for ; Thu, 29 Jul 2021 17:37:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A268C393BC1F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway31.websitewelcome.com (Postfix) with ESMTP id BB75710CA53 for ; Thu, 29 Jul 2021 12:30:57 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 99s0mXhP2LjoR99s0mokEx; Thu, 29 Jul 2021 12:30:57 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nU1GFTxLCRcRN/IKQ7iaeJjxkZ4dRDOmAnn1NDPfGWg=; b=InUTMuelfU6uk4+oNh6eiKGtXr EsG4UUa7IN3h56NT7hEOaaELf+bqZs5V+xEwuT9NmKfC2ZgCOvr9hw/HOz0s6isWG4ItjStBN4jtU T5IsAKTc1H0Md/1/pgh1Q86L+; Received: from 97-122-74-117.hlrn.qwest.net ([97.122.74.117]:44418 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m99rz-000y1I-4k; Thu, 29 Jul 2021 11:30:55 -0600 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , "gdb-patches@sourceware.org" , Andrew Burgess Subject: Re: [master + 11][gdb/build] Disable attribute nonnull References: <20210726211101.ivychvbfgaafxjtz@lug-owl.de> <20210727100354.GB4037238@embecosm.com> <20210727113511.GC4037238@embecosm.com> <6cf80ba9-b010-bb42-c92d-84e4f396813c@suse.de> X-Attribution: Tom Date: Thu, 29 Jul 2021 11:30:54 -0600 In-Reply-To: (Tom de Vries's message of "Thu, 29 Jul 2021 13:42:15 +0200") Message-ID: <87r1fhauy9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.74.117 X-Source-L: No X-Exim-ID: 1m99rz-000y1I-4k X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-74-117.hlrn.qwest.net (murgatroyd) [97.122.74.117]:44418 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2021 17:37:22 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> The current conclusion is that it's best to disable this. This is explained Tom> at length in the gdbsupport/common-defs.h comment. FWIW this looks reasonable to me. I would recommend waiting a little to see if anyone else disagrees. Normally I'd say let's simply not use ATTRIBUTE_NONNULL, but one thing I like about your approach is that it provides a spot to put this great comment you wrote. Tom