From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gnulib: allow control over srcdir
Date: Thu, 10 Jun 2021 12:15:32 -0600 [thread overview]
Message-ID: <87r1h9io1n.fsf@tromey.com> (raw)
In-Reply-To: <YMDzJDvaYpDkFRkV@vapier> (Mike Frysinger's message of "Wed, 9 Jun 2021 12:58:12 -0400")
Mike> since we can't assume GNU make, i was going to rename it to GNULIB_LOCAL_SRCDIR
Mike> unless someone wants to bikeshed a diff name.
I think it's fine to assume GNU make, Makefile.gnulib.inc already seems
to with its use of $(error)
Anyway, one idea is to replace GNULIB_BUILDDIR with a variable that just
indicates how to reach top-of-entire-tree from the Makefile in question,
like:
# gdb or whatever sets:
top_of_tree = ../..
# gnulib does:
GNULIB_BUILDDIR = $(top_of_tree)/gnulib
INCGNU = -I$(srcdir)/$(top_of_tree)/gnulib/import
>> This file isn't actually used any more by gdb.
Mike> seems to be ? gdb/Makefile.in & gdbserver/Makefile.in have:
Ugh, sorry. grep fail by me.
Tom
next prev parent reply other threads:[~2021-06-10 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 22:06 Mike Frysinger
2021-06-09 14:47 ` Tom Tromey
2021-06-09 16:58 ` Mike Frysinger
2021-06-10 18:15 ` Tom Tromey [this message]
2021-06-13 5:23 ` [PATCH] gnulib: define the path to gnulib's parent dir Mike Frysinger
2021-06-14 15:23 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1h9io1n.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).