From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.196.18]) by sourceware.org (Postfix) with ESMTPS id 00083385783E for ; Thu, 10 Jun 2021 18:15:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 00083385783E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 4479F783C for ; Thu, 10 Jun 2021 13:15:33 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id rPDJlc5aMhbxprPDJlO02p; Thu, 10 Jun 2021 13:15:33 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OXhPbAu46emDStHLQfNGytk0HzsHm/nHf0K4PlrHp0M=; b=sG9GzItRQ/BoB7jrU6IWEyYVX3 sPvLYqAuUfNwPGsMnvtu/Qi5QHeCW4E+rMoNEXsRypnZOFffJMQwhTvoUewWTuAjd88HZBaqFPs+c AjnEb01y8E99IELvCACVsMOlg; Received: from 97-122-81-113.hlrn.qwest.net ([97.122.81.113]:41090 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lrPDI-004C36-WA; Thu, 10 Jun 2021 12:15:33 -0600 From: Tom Tromey To: Tom Tromey Cc: Mike Frysinger via Gdb-patches Subject: Re: [PATCH] gnulib: allow control over srcdir References: <20210608220639.1975-1-vapier@gentoo.org> <87czsvjdr6.fsf@tromey.com> X-Attribution: Tom Date: Thu, 10 Jun 2021 12:15:32 -0600 In-Reply-To: (Mike Frysinger's message of "Wed, 9 Jun 2021 12:58:12 -0400") Message-ID: <87r1h9io1n.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.113 X-Source-L: No X-Exim-ID: 1lrPDI-004C36-WA X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-113.hlrn.qwest.net (murgatroyd) [97.122.81.113]:41090 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2021 18:15:36 -0000 Mike> since we can't assume GNU make, i was going to rename it to GNULIB_LOCAL_SRCDIR Mike> unless someone wants to bikeshed a diff name. I think it's fine to assume GNU make, Makefile.gnulib.inc already seems to with its use of $(error) Anyway, one idea is to replace GNULIB_BUILDDIR with a variable that just indicates how to reach top-of-entire-tree from the Makefile in question, like: # gdb or whatever sets: top_of_tree = ../.. # gnulib does: GNULIB_BUILDDIR = $(top_of_tree)/gnulib INCGNU = -I$(srcdir)/$(top_of_tree)/gnulib/import >> This file isn't actually used any more by gdb. Mike> seems to be ? gdb/Makefile.in & gdbserver/Makefile.in have: Ugh, sorry. grep fail by me. Tom