Re: [PATCH 0/1] Integrate GNU poke in GDB

["Jose E. Marchesi" <jose.marchesi@oracle.com>]

>>>>>> "Jose" == Jose E Marchesi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Jose> poke STR
> Jose> poke-add-type EXPR
> Jose> poke-add-types REGEXP
> Jose> poke-dump-types
>
>>> It's maybe more gdb-ish to make one command and use subcommands.
>
> Jose> What would be the gdb-ish way:
>
> Jose> a) poke STR
> Jose>    poke add-type EXPR
> Jose>    poke add-types REGEXP
> Jose>    poke dump-types
>
> Jose> or
>
> Jose> b) poke STR
> Jose>    poke add type EXPR
> Jose>    poke add types REGEXP
> Jose>    poke dump types
>
> Jose> Because a) will be problematic: `add-types' can be a valid Poke
> Jose> expression if both `add' and `types' are defined as variables.
>
> Jose> Doing b) would be ok I think.
>
> Either is fine, though (b) is more of a pain to implement.  If the plain
> prefix command is ambiguous, you can have it work like "set", where "set X"
> evaluates X, but "set var" is a subcommand to avoid the ambiguous case.

Ok, I will go with a) using that strategy.

> Jose> But I am not really looking forward to write Python bindings for libpoke
> Jose> (or Python for anything for that matter) and even if I could recruit
> Jose> someone to do that work, the stuff would need to be maintained ... poke
> Jose> depending on Python, supporting future Python versions and what not,
> Jose> argh no no no no :)
>
> Just to be clear, gdb often has a high burden to get a patch in.

That's pefectly fine.  I have contributed to GDB before.

> For example, do you have a gdb copyright assignment in place?  We can't
> accept your patch until that's done.

I can contribute it under my employer's assignment.

I will sign a personal assignment for GDB anyway; I looked in fencepost
and I don't have one in place.  It is super fast and easy to do so
nowadays using PDF documents (at least from Germany.)

Thanks!