From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Add virtual destructor to dwarf2_per_cu_data
Date: Tue, 04 May 2021 09:34:32 -0600 [thread overview]
Message-ID: <87r1imsebb.fsf@tromey.com> (raw)
In-Reply-To: <20210503193206.4008066-2-tromey@adacore.com> (Tom Tromey's message of "Mon, 3 May 2021 13:32:04 -0600")
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Tom> Address sanitizer pointed out that the patch to use 'delete' for
Tom> dwarf2_per_cu_data introduced a bug -- now it is possible to delete a
Tom> signatured_type using a pointer to its base class. This patch fixes
Tom> the problem by introducing a virtual destructor.
I'm thinking that instead I should add a custom deleter for these
objects that knows to cast to signatured_type when appropriate. This
would avoid a vtable pointer just to hold the destructor.
Tom
next prev parent reply other threads:[~2021-05-04 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 19:32 [PATCH 0/3] Fix some sanitizer errors Tom Tromey
2021-05-03 19:32 ` [PATCH 1/3] Add virtual destructor to dwarf2_per_cu_data Tom Tromey
2021-05-04 15:34 ` Tom Tromey [this message]
2021-05-06 17:23 ` Tom Tromey
2021-05-03 19:32 ` [PATCH 2/3] Fix buffer underflow in add_path Tom Tromey
2021-05-06 14:53 ` Tom de Vries
2021-05-03 19:32 ` [PATCH 3/3] Fix ubsan build Tom Tromey
2021-05-17 18:53 ` [PATCH 0/3] Fix some sanitizer errors Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1imsebb.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).