From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove parameter from language_info
Date: Mon, 29 Mar 2021 09:35:42 -0600 [thread overview]
Message-ID: <87r1jyug4x.fsf@tromey.com> (raw)
In-Reply-To: <dbbc383b-598e-dcf7-a0e8-16b5bf51dec6@polymtl.ca> (Simon Marchi's message of "Mon, 29 Mar 2021 10:38:35 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> Thanks, that LGTM (obvious even). I would suggest moving the function
Simon> comment to the header at the same time.
Good idea. I made this change and now I'm checking it in.
Tom
prev parent reply other threads:[~2021-03-29 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 14:26 Tom Tromey
2021-03-29 14:38 ` Simon Marchi
2021-03-29 15:35 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1jyug4x.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).