From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tromey@adacore.com>
Received: from rock.gnat.com (rock.gnat.com
 [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1])
 by sourceware.org (Postfix) with ESMTP id E135A385702E
 for <gdb-patches@sourceware.org>; Mon, 29 Mar 2021 15:35:43 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E135A385702E
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=adacore.com
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=tromey@adacore.com
Received: from localhost (localhost.localdomain [127.0.0.1])
 by filtered-rock.gnat.com (Postfix) with ESMTP id AAC56116CD6;
 Mon, 29 Mar 2021 11:35:43 -0400 (EDT)
X-Virus-Scanned: Debian amavisd-new at gnat.com
Received: from rock.gnat.com ([127.0.0.1])
 by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id zRhHjmRkd7Z7; Mon, 29 Mar 2021 11:35:43 -0400 (EDT)
Received: from murgatroyd (71-211-130-165.hlrn.qwest.net [71.211.130.165])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by rock.gnat.com (Postfix) with ESMTPSA id 4DDF3116AA1;
 Mon, 29 Mar 2021 11:35:43 -0400 (EDT)
From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove parameter from language_info
References: <20210329142606.2501921-1-tromey@adacore.com>
 <dbbc383b-598e-dcf7-a0e8-16b5bf51dec6@polymtl.ca>
X-Attribution: Tom
Date: Mon, 29 Mar 2021 09:35:42 -0600
In-Reply-To: <dbbc383b-598e-dcf7-a0e8-16b5bf51dec6@polymtl.ca> (Simon Marchi's
 message of "Mon, 29 Mar 2021 10:38:35 -0400")
Message-ID: <87r1jyug4x.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Mar 2021 15:35:44 -0000

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> Thanks, that LGTM (obvious even).  I would suggest moving the function
Simon> comment to the header at the same time.

Good idea.  I made this change and now I'm checking it in.

Tom