From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/objc: make objc_demangle a member function of objc_language
Date: Fri, 19 Mar 2021 11:57:35 -0600 [thread overview]
Message-ID: <87r1kbvxf4.fsf@tromey.com> (raw)
In-Reply-To: <20210316190204.2710358-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Tue, 16 Mar 2021 19:02:04 +0000")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> Makes the objc_demangle helper function a member function of
Andrew> objc_language (by renaming it to be the demangle_symbol member
Andrew> function).
Andrew> I also fixed some of the obvious coding standard violations in
Andrew> obj_demangle, so the '&&' operators are now at the start of the line,
Andrew> not the end. Comparison to nullptr are now made explicit, as are
Andrew> comparisons to the null character.
Andrew> There should be no user visible changes after this commit.
It looks reasonable to me.
I think Objective C testing hasn't really worked for me for a while.
Most of the real tests fail due to compilation errors.
Tom
prev parent reply other threads:[~2021-03-19 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 19:02 Andrew Burgess
2021-03-16 22:47 ` Lancelot SIX
2021-03-22 11:36 ` Andrew Burgess
2021-03-19 17:57 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1kbvxf4.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).