From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.4.169]) by sourceware.org (Postfix) with ESMTPS id 8377E385783D for ; Fri, 19 Mar 2021 17:57:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8377E385783D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 7F37E400D747F for ; Fri, 19 Mar 2021 12:48:13 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id NJNQlymi8b8LyNJNQlRY2a; Fri, 19 Mar 2021 12:57:36 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=i7MHsgvP7pl3iRPhko+fpNx6qGiK+o+mcNZdnOz2NeM=; b=yR80vFr327SwrIU/bq4TviVYuU xw6o2vmxr2NE5jyJBamvkJU/XPGxclGSNLRE8Ps+lQ5X8L3H6jpEevhr6rySsM0h4fq3dTE2uQnbv xhclGN17DtWhGOB40eJ7PpRd1; Received: from 71-211-137-228.hlrn.qwest.net ([71.211.137.228]:50282 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lNJNQ-000IF1-Fa; Fri, 19 Mar 2021 11:57:36 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/objc: make objc_demangle a member function of objc_language References: <20210316190204.2710358-1-andrew.burgess@embecosm.com> X-Attribution: Tom Date: Fri, 19 Mar 2021 11:57:35 -0600 In-Reply-To: <20210316190204.2710358-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Tue, 16 Mar 2021 19:02:04 +0000") Message-ID: <87r1kbvxf4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.137.228 X-Source-L: No X-Exim-ID: 1lNJNQ-000IF1-Fa X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-137-228.hlrn.qwest.net (murgatroyd) [71.211.137.228]:50282 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Mar 2021 17:57:39 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> Makes the objc_demangle helper function a member function of Andrew> objc_language (by renaming it to be the demangle_symbol member Andrew> function). Andrew> I also fixed some of the obvious coding standard violations in Andrew> obj_demangle, so the '&&' operators are now at the start of the line, Andrew> not the end. Comparison to nullptr are now made explicit, as are Andrew> comparisons to the null character. Andrew> There should be no user visible changes after this commit. It looks reasonable to me. I think Objective C testing hasn't really worked for me for a while. Most of the real tests fail due to compilation errors. Tom