From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.91]) by sourceware.org (Postfix) with ESMTPS id 1A2A93861000 for ; Fri, 9 Oct 2020 18:33:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1A2A93861000 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 5BAC9400CBD3D for ; Fri, 9 Oct 2020 13:33:54 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id QxDGk5tZbBD8bQxDGk7IVd; Fri, 09 Oct 2020 13:33:54 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=s5cgBbN233ZTx9qHpG9EBSbXzEk2CiLSs5/AHp/4tvY=; b=nzOUMrlX2V3Qeo+vEr+SH5if8o TfMDKDuAZab8TRRwJctBlKay4IJjdlNK+Un82LOWo93pRv0YKAmfYBZRE3nYjTIMMrNYsdvyTEmaS AYYY9wqAzY4kYYcEb6QFKUD1m; Received: from 174-16-122-38.hlrn.qwest.net ([174.16.122.38]:50920 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kQxDG-001Vwu-2u; Fri, 09 Oct 2020 12:33:54 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: detect main function even when there's no matching msymbol References: <20201008150855.2113290-1-andrew.burgess@embecosm.com> X-Attribution: Tom Date: Fri, 09 Oct 2020 12:33:53 -0600 In-Reply-To: <20201008150855.2113290-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Thu, 8 Oct 2020 16:08:55 +0100") Message-ID: <87r1q7b65q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.122.38 X-Source-L: No X-Exim-ID: 1kQxDG-001Vwu-2u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-122-38.hlrn.qwest.net (murgatroyd) [174.16.122.38]:50920 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2020 18:33:57 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> Currently, GDB will only stop the backtrace at the main function if Andrew> there is a minimal symbol with the matching name. In Fortran programs Andrew> compiled with gfortran this is not the case. The main function is Andrew> present in the DWARF, and as marked as DW_AT_main_subprogram, but Andrew> there's no minimal symbol. Andrew> This commit extends `inside_main_func` to check the full symbols if no Andrew> matching minimal symbol is found. Andrew> There's an updated test case that covers this change. Andrew> gdb/ChangeLog: Andrew> * frame.c (inside_main_func): Check full symbols as well as Andrew> minimal symbols. This looks good to me. Thank you. Tom