Re: [PATCH 0/7] Language Class Hierarchy Conversion (Prt 3)

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> In this third patch set I convert the last remaining function pointers
Andrew> in the language_base structure into member function in language_defn.

Andrew> There wasn't anything particularaly tricky in this batch.

I skimmed these and it all seems fine to me.

Andrew> After this set my plans are (in no particular order):

Andrew>   - Convert at least some of the data members in language_base into
Andrew>     member function in language_defn.

Andrew>   - Move some of the language classes into header files so that member
Andrew>     functions can be defined in different .c files.  This will allow
Andrew>     me to remove most of the member functions that currently just
Andrew>     redirect to a function in another file.

Andrew>   - Possibly restructure the language class hierarchy to increase the
Andrew>     amount of sharing that exists between similar languages.

Andrew>   - Make more of the per-language helper functions private functions
Andrew>     within the language classes.

Andrew> Thoughts, feedback, or ideas always welcome.

I wouldn't mind getting rid of the LA_* macros.  Especially after this
series, I don't think they add much.

Tom