From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.140]) by sourceware.org (Postfix) with ESMTPS id 732693851C0D for ; Fri, 19 Jun 2020 14:25:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 732693851C0D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway21.websitewelcome.com (Postfix) with ESMTP id D843740129829 for ; Fri, 19 Jun 2020 09:25:57 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id mHxtjcpf4XGIkmHxtj8zXv; Fri, 19 Jun 2020 09:25:57 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Yi2dsz5Gp9djh8/VzlZpT4slSvH2uT893LkkQru507w=; b=CeNnLX8mkamsihCVOjiJllHyqs 4qKk7L7QEXKEKajw+adFiXK7m61KAacNqTNb0G9zB4wQ+pZteI8PBu8SXxs9fKvtlgLXKm50XXhQ9 63sHKUMXdc3c3pRJ1bErOrFgl; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:60214 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jmHxt-002lnn-I8; Fri, 19 Jun 2020 08:25:57 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Language Class Hierarchy Conversion (Prt 3) References: X-Attribution: Tom Date: Fri, 19 Jun 2020 08:25:56 -0600 In-Reply-To: (Andrew Burgess's message of "Thu, 18 Jun 2020 23:31:47 +0100") Message-ID: <87r1ubxhcb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jmHxt-002lnn-I8 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:60214 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2020 14:26:00 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> In this third patch set I convert the last remaining function pointers Andrew> in the language_base structure into member function in language_defn. Andrew> There wasn't anything particularaly tricky in this batch. I skimmed these and it all seems fine to me. Andrew> After this set my plans are (in no particular order): Andrew> - Convert at least some of the data members in language_base into Andrew> member function in language_defn. Andrew> - Move some of the language classes into header files so that member Andrew> functions can be defined in different .c files. This will allow Andrew> me to remove most of the member functions that currently just Andrew> redirect to a function in another file. Andrew> - Possibly restructure the language class hierarchy to increase the Andrew> amount of sharing that exists between similar languages. Andrew> - Make more of the per-language helper functions private functions Andrew> within the language classes. Andrew> Thoughts, feedback, or ideas always welcome. I wouldn't mind getting rid of the LA_* macros. Especially after this series, I don't think they add much. Tom