From: Tom Tromey <tom@tromey.com>
To: Philippe Waroquiers via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA 06/10] Fix inconsistent output of prefix and bugs in 'show' command
Date: Thu, 14 May 2020 10:16:40 -0600 [thread overview]
Message-ID: <87r1vm1ogn.fsf@tromey.com> (raw)
In-Reply-To: <20200510205530.21923-7-philippe.waroquiers@skynet.be> (Philippe Waroquiers via Gdb-patches's message of "Sun, 10 May 2020 22:55:26 +0200")
>>>>> "Philippe" == Philippe Waroquiers via Gdb-patches <gdb-patches@sourceware.org> writes:
Philippe> YYYY-MM-DD Philippe Waroquiers <philippe.waroquiers@skynet.be>
Philippe> * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
Philippe> * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
Philippe> * command.h (cmd_show_list): Likewise.
Philippe> * dwarf2/index-cache.c (show_index_cache_command): Likewise.
Philippe> * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output. Skip aliases.
Looks good. Thank you.
Philippe> - if (list->prefixlist && !list->abbrev_flag)
Philippe> + if (list->prefixlist && list->cmd_pointer == nullptr)
It wasn't immediately apparent to me why checking cmd_pointer is the
correct thing to do here, but that's just because I forgot what it was
for. The comment in cli-decode.h made it clear.
Tom
next prev parent reply other threads:[~2020-05-14 16:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 20:55 [RFA 00/10] fix/improve cmd structure, class_alias, help, apropos Philippe Waroquiers
2020-05-10 20:55 ` [RFA 01/10] Add a selftest that detects a 'corrupted' command tree structure in GDB Philippe Waroquiers
2020-05-14 15:51 ` Tom Tromey
2020-05-10 20:55 ` [RFA 02/10] Fix the only incorrect case found by command_structure_invariants selftest Philippe Waroquiers
2020-05-14 15:52 ` Tom Tromey
2020-05-10 20:55 ` [RFA 03/10] Fix problem that alias can be defined or not depending on the order Philippe Waroquiers
2020-05-14 16:00 ` Tom Tromey
2020-05-10 20:55 ` [RFA 04/10] command-def-selftests.c: detect missing or wrong prefix cmd in subcommands Philippe Waroquiers
2020-05-14 15:54 ` Tom Tromey
2020-05-10 20:55 ` [RFA 05/10] Fix the problems reported by prefix check of command-def-selftests.c Philippe Waroquiers
2020-05-14 16:07 ` Tom Tromey
2020-05-10 20:55 ` [RFA 06/10] Fix inconsistent output of prefix and bugs in 'show' command Philippe Waroquiers
2020-05-14 16:16 ` Tom Tromey [this message]
2020-05-10 20:55 ` [RFA 07/10] Fix/improve 'help CLASS' output Philippe Waroquiers
2020-05-14 16:26 ` Tom Tromey
2020-05-10 20:55 ` [RFA 08/10] Fix/improve 'apropos' output Philippe Waroquiers
2020-05-14 16:30 ` Tom Tromey
2020-05-10 20:55 ` [RFA 09/10] Ensure class_alias is only used for user-defined aliases Philippe Waroquiers
2020-05-14 17:33 ` Tom Tromey
2020-05-14 21:12 ` Philippe Waroquiers
2020-05-10 20:55 ` [RFA 10/10] Update NEWS and documentation for help and apropos changes Philippe Waroquiers
2020-05-11 14:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1vm1ogn.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).