From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.144.95]) by sourceware.org (Postfix) with ESMTPS id DA5F03840C05 for ; Thu, 14 May 2020 20:18:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DA5F03840C05 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 60E0E74D4A for ; Thu, 14 May 2020 15:18:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ZKJZjwoUlVQh0ZKJZj1PJf; Thu, 14 May 2020 15:18:45 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5TH32vMt8TZg2Hr0w9fetAJkJOSquVpPb8R2oiSSX3Y=; b=Zdw3RMJ+V44I2kqSmsEC1S+XoJ N7DPqRtC/sDmhY08B3FHfjk1RDEmOdCMQUjtMDgfSmB0YWYWRkvsh+ENCRPIY7+y99q79ClcsqokO 4eVEnfV5LRcOMAjqZLLjzVx0C; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:37904 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jZKJZ-001gDO-54; Thu, 14 May 2020 14:18:45 -0600 From: Tom Tromey To: Andrew Burgess Cc: Bernd Edlinger , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: Preserve is-stmt lines when switch between files References: <6e9b21a0002164cec014dfe4d94d816a376989b4.1585952198.git.andrew.burgess@embecosm.com> <20200414112841.GC2366@embecosm.com> <20200416171809.GJ2366@embecosm.com> <87lfmnql4g.fsf@tromey.com> <20200427103418.GF3522@embecosm.com> X-Attribution: Tom Date: Thu, 14 May 2020 14:18:44 -0600 In-Reply-To: <20200427103418.GF3522@embecosm.com> (Andrew Burgess's message of "Mon, 27 Apr 2020 11:34:18 +0100") Message-ID: <87r1vmuv6j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jZKJZ-001gDO-54 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:37904 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2020 20:18:56 -0000 >>>>> "Andrew" == Andrew Burgess writes: Resurrecting this again ... we have some internal tests that have been failing, and I want to land at least one of these patches to resolve this. Andrew> After reading[2] I'd also be interest to understand what flaw in Andrew> DWARF you feel makes a difference in this case. I also don't understand this. Andrew> I think it is great Bernd, that you are reaching out from the GCC Andrew> community to engage with GDB, this is certainly the best way to ensure Andrew> that we can work together as communities to give the best possible Andrew> debug experience, and I'm sorry you feel that I have not been clear Andrew> enough about the issues I'm seeing here. +1 Andrew> I don't know how we address this without merging your patch, Andrew> releasing GDB and seeing how it works in the wild. However, if we Andrew> did decide to "just try it", I would still prefer we staged things Andrew> as: Andrew> (a) Merge my patch, targeted regression fix, then Andrew> (b) Your patch, new functionality GCC/DWARF ranges work around. Andrew> In this way, if we end up backing out some or all of (b) we still Andrew> have (a) in place that fixes the regression. I'm more than happy Andrew> for a rebase of (b) in include full removal of (a). I think landing your patch is safe to do while we discuss part (b). How about we move forward with that part? Then if we come to agreement on where the bug lies we can decide about that. Tom