From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93840 invoked by alias); 24 Feb 2020 03:07:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93831 invoked by uid 89); 24 Feb 2020 03:07:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2051, neglected, sk:reorgan, H*f:sk:8b11c5f X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.94) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Feb 2020 03:07:06 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 638FF22B80 for ; Sun, 23 Feb 2020 21:07:05 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 645JjuTAdSl8q645JjZlYX; Sun, 23 Feb 2020 21:07:05 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jbAW3dHJeZY12m0XzeZ7cPSZHN99zVTYXddg20Cnshg=; b=JprvIFfce9Rsj1TpuDOMJ8kHzX sKR4sdVvv75N76DaL4yHvvLl84GSUUEvOAffi56ceRHTP5tgjM3GIubPAXpsbf1lz8c8bB1Oe7h7b Ztk40RpEdDdooPM6/I7DtCezK; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:46530 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j645J-003ZY9-5e; Sun, 23 Feb 2020 20:07:05 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 00/14] Share DWARF partial symtabs between objfiles References: <20200215165444.32653-1-tom@tromey.com> <87y2ss5019.fsf@tromey.com> <8b11c5f6-771f-69b5-c98c-94ced592132f@simark.ca> Date: Mon, 24 Feb 2020 03:07:00 -0000 In-Reply-To: <8b11c5f6-771f-69b5-c98c-94ced592132f@simark.ca> (Simon Marchi's message of "Sun, 23 Feb 2020 21:52:03 -0500") Message-ID: <87r1ykn0o7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00912.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> A few of these patches (1-3, 5, and 11) could probably go in sooner. >> What do you think of that? Simon> #1 is already in, right? Simon> #2: Yes, sounds like a good cleanup. Simon> #4: Yes, good cleanup. Simon> #3: It's only useful if we end up doing psymtabs sharing, so I would not push Simon> it yet. Simon> #5 and #11: I'm not sure how much of that I end up un-doing in my prototype patch, Simon> swapping the shareable and unshareable parts. And it is also only useful in Simon> the context of psymtab sharing, so I wouldn't push it yet. Ugh, I used the wrong numbers. #1 is already in, so really I mean #2-#4, #6, #12. #2 (simplify setting of reading_partial_symbols) #3 dwarf2_per_objfile::obstack #4 TYPE_UNIT_GROUP method #6 Add "objfile" parameter to two partial_symtab methods #12 Fix a memory leak Maybe the baton change could be done as well. Simon> I'm currently experimenting with what I suggested above, this is what I have for Simon> now (this will get force-pushed as I progress): Simon> https://github.com/simark/binutils-gdb/commits/share-psymtabs Simon> The status is: I'm based on your patch 9/14 ("Add objfile member to DWARF batons"), Simon> as it aims mainly to replace patch patch 10/14 ("Introduce dwarf2_enter_objfile and Simon> use it") with the architecture I proposed. I see no regression in a simple Simon> "make check" between it and the previous commit. I have yet to apply and adapt the Simon> rest of your series on top of my commit. I would also like to test with the variety Simon> of testsuite boards that Tom de Vries added, since they will test various DWARF Simon> configurations (and I would feel bad if he had to clean up after us again). Yeah. Take a look at my branch, t/reorganize-dwarf-code-sharing-3. I rearranged it to move all the "unshared" stuff to the end, so there should be less to fix up (though I see now I neglected to move the baton patch earlier). Tom