From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112870 invoked by alias); 19 Dec 2019 18:17:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112861 invoked by uid 89); 19 Dec 2019 18:17:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=wish X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 18:17:37 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 6393910C21 for ; Thu, 19 Dec 2019 12:17:36 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id i0Miizfd5qNtvi0MiigiaR; Thu, 19 Dec 2019 12:17:36 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=u8mXxTZ8NighvACi2ZZDQPExwfdDVDHuJQk6eBCpWmk=; b=nwn04H+NHiWr9PHY8jthb9CWTs 6OOLfO5rL0OlmlgV8z7Mp4TxYX4TURZoVpcIycEx8pBphCVRdBMfaS2phK3bgw5zeofv3HHwcFEwY u1orGoqXLh9M2IsmvifQVj46R; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:37466 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ii0Mi-0016Qr-5W; Thu, 19 Dec 2019 11:17:36 -0700 From: Tom Tromey To: Eli Zaretskii Cc: Christian Biesinger , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Cast the log10 argument to double to disambiguate it References: <20191219000103.36667-1-cbiesinger@google.com> <20191219000103.36667-4-cbiesinger@google.com> <838sn92dja.fsf@gnu.org> Date: Thu, 19 Dec 2019 18:17:00 -0000 In-Reply-To: <838sn92dja.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Dec 2019 05:35:21 +0200") Message-ID: <87r210b2o0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00826.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: >> Date: Wed, 18 Dec 2019 18:01:02 -0600 >> From: "Christian Biesinger via gdb-patches" >> Cc: Christian Biesinger >> >> On Solaris 11 with gcc 5.5.0 (gcc211 on the compile farm), math.h has a >> using std::log10; directive. This is unfortunate because std::log10 has >> overloads for float/double/long double. To disambiguate this call, >> cast the argument to double to fix the build. Eli> We may wish to have a comment in the code referring to the original Eli> problem, including perhaps the OS and the compiler versions? Eli> Otherwise the need for this cast is not immediately obvious, IMO. Agreed; this is ok with that change. Tom