From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57663 invoked by alias); 1 Dec 2019 18:59:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57652 invoked by uid 89); 1 Dec 2019 18:59:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=unavailable version=3.3.1 spammy=sides, arrow, border X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.66.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 01 Dec 2019 18:59:07 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 04FE9400C5791 for ; Sun, 1 Dec 2019 11:49:13 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id bUQzighTD4kpjbUQziHz0e; Sun, 01 Dec 2019 12:59:05 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hJMUOcddOzrSSkO/tpCSh/6aDmoe9OlZXoARBnOgsHE=; b=ixYyvGPOjrtbUUjbQoKb+iOm5A 0gLLhrhrewQiOcaLNqXYh2PKVaunmPuO20zPtVWE6rKPSn6Wp5pMq4NMoqeVpNV6RMpIrP2fA9JGl ymFT/3dR7GSDXFHxVOthg+Sgy; Received: from 97-118-104-188.hlrn.qwest.net ([97.118.104.188]:47170 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ibUQz-002BLI-Om; Sun, 01 Dec 2019 11:59:05 -0700 From: Tom Tromey To: "Andrew Burgess \(Code Review\)" Cc: Tom Tromey , gdb-patches@sourceware.org, gnutoolchain-gerrit@osci.io Subject: Re: [review v2] Add TUI border colors References: <20191127001344.292FC20AF6@gnutoolchain-gerrit.osci.io> Date: Sun, 01 Dec 2019 18:59:00 -0000 In-Reply-To: <20191127001344.292FC20AF6@gnutoolchain-gerrit.osci.io> (Andrew Burgess's message of "Tue, 26 Nov 2019 19:13:43 -0500") Message-ID: <87r21nq3d2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00012.txt.bz2 >>>>> "Andrew" == Andrew Burgess (Code Review) writes: Andrew> I spotted some weird behaviour: [...] Andrew> At this point you should be in SRC/ASM/CMD layout with the ASM Andrew> window focused, and its border coloured on just three sides, Andrew> left, right, and bottom. Andrew> - Scroll the view up (up arrow key), and the top border suddenly becomes coloured. Andrew> This seems a little odd! I agree, but I tried with an unmodified gdb and I can reproduce the bug there. So, because it isn't introduced by this series, I'm going to go ahead and check in these patches. This can probably be fixed. Maybe we can arrange to always draw the focus window's border last. This is a little weird, though, since then it will always overwrite any other window title that might ordinarily appear there. Maybe we could also get rid of the highlighting along the borders of the terminal, which would free up a little space for content. Not sure. Tom