From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18833 invoked by alias); 2 Jul 2019 15:01:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18825 invoked by uid 89); 2 Jul 2019 15:01:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 Jul 2019 15:01:37 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2DC8756089; Tue, 2 Jul 2019 11:01:36 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id C4j4kEZaI3vN; Tue, 2 Jul 2019 11:01:36 -0400 (EDT) Received: from murgatroyd (174-29-48-143.hlrn.qwest.net [174.29.48.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id AB13E56087; Tue, 2 Jul 2019 11:01:35 -0400 (EDT) From: Tom Tromey To: "Metzger\, Markus T" Cc: Tom Tromey , "gdb-patches\@sourceware.org" Subject: Re: [PATCH 3/3] Introduce field_unsigned References: <20190701200058.16235-1-tromey@adacore.com> <20190701200058.16235-4-tromey@adacore.com> <87ftnoocaz.fsf@tromey.com> Date: Tue, 02 Jul 2019 15:01:00 -0000 In-Reply-To: (Markus T. Metzger's message of "Tue, 2 Jul 2019 12:41:35 +0000") Message-ID: <87r278mqep.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00047.txt.bz2 >> If subclasses don't need to know that the field was originally an integer or a float, >> all of ui_out can be reduced to outputting strings and sub-classes need only provide >> that one member function for all field types. >> I don't have any preference one way or another, I was mainly commenting on the >> apparent discrepancy how similar field types are handled. I suppose if we ever want to, say, switch MI to use JSON, then preserving the difference would make sense. I'll change it. Tom