From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97497 invoked by alias); 31 Oct 2018 20:37:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97476 invoked by uid 89); 31 Oct 2018 20:37:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1116 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Oct 2018 20:37:09 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A7E723081252; Wed, 31 Oct 2018 20:37:08 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F89116C61; Wed, 31 Oct 2018 20:37:08 +0000 (UTC) From: Sergio Durigan Junior To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Avoid crash when calling warning too early References: <20181031181820.24308-1-tom@tromey.com> <875zxi9csd.fsf@redhat.com> <87y3adn9o8.fsf@tromey.com> Date: Wed, 31 Oct 2018 20:37:00 -0000 In-Reply-To: <87y3adn9o8.fsf@tromey.com> (Tom Tromey's message of "Wed, 31 Oct 2018 14:27:51 -0600") Message-ID: <87r2g597kb.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00764.txt.bz2 On Wednesday, October 31 2018, Tom Tromey wrote: >>>>>> "Sergio" == Sergio Durigan Junior writes: > > Sergio> This seems OK to me, and was also what part of what I was planning to do > Sergio> to fix: > Sergio> https://sourceware.org/bugzilla/show_bug.cgi?id=23555 > Sergio> Could you please also mention this bug on the ChangeLog? Your patch > Sergio> doesn't fully fix the issue, but it avoids the segfault at least. > > If you want, I can just drop this and you can take over. Thanks, but I'd prefer if you checked your patch in. The bug reported on 23555 is actually composed of two issues: (a) what to do when GDB can't determine the CWD, and (b) the segmentation fault that happens when we try to call warning too early in the code. Your patch fixes (b), and I still didn't sit down to figure out how to approach (a). So it's best if we just go ahead and avoid the segfault for now. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/