From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122171 invoked by alias); 16 Aug 2018 23:46:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122158 invoked by uid 89); 16 Aug 2018 23:46:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=benson, Benson X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.250) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Aug 2018 23:46:00 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 091476595 for ; Thu, 16 Aug 2018 18:45:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id qRxZfKqdyPvAdqRxgfKWsB; Thu, 16 Aug 2018 18:45:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d3spb73dcTziQSqrzGaKy5OuD+U8DhFHPYGakaC45Tc=; b=ZIJWnhYmdrZkIEif5QW2ZlDXM9 jVfE95NTiQVKymxne/z7lAD8rPT0TQhwJPUf5ueSCIPQ0CPmgtMOCqGVzS6sokQ7EQjpqTSvlw1zF Nm9zS0fTAv+zB4tpKi6HjDFXT; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:38800 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fqRxY-003V1t-Px; Thu, 16 Aug 2018 18:45:44 -0500 From: Tom Tromey To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Indicate batch mode failures by exiting with nonzero status References: <1534425783-11599-1-git-send-email-gbenson@redhat.com> Date: Thu, 16 Aug 2018 23:46:00 -0000 In-Reply-To: <1534425783-11599-1-git-send-email-gbenson@redhat.com> (Gary Benson's message of "Thu, 16 Aug 2018 14:23:03 +0100") Message-ID: <87r2ix98pk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00418.txt.bz2 >>>>> "Gary" == Gary Benson writes: Gary> +/* Did the last invocation of catch_command_errors throw an error? */ Gary> + Gary> +static bool last_command_failed = false; catch_command_errors seems to return a boolean, so I think a global shouldn't be necessary. Also, why just the last command? I mean, I guess I don't really know what I would expect, but maybe if any command failed, gdb should exit? Right now there seems to be a discrepancy where if you do "gdb -ex fail -ex fail -ex fail", each one will be run; but if you put the commands into a file and "gdb -x file", then only the first one will be run. I'm not sure if this is good or bad. I suppose one nice thing about the "last command only" approach is that you could ignore failures by tacking on one more -ex with some sort of no-op. Tom