From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26403 invoked by alias); 16 Jul 2018 16:41:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26361 invoked by uid 89); 16 Jul 2018 16:41:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.150.114) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Jul 2018 16:41:13 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway34.websitewelcome.com (Postfix) with ESMTP id D9EE62A5981 for ; Mon, 16 Jul 2018 11:41:11 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id f6XuflFPobXuJf6YNftI9J; Mon, 16 Jul 2018 11:41:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BNLT2PyozDlPXSuo6FXGsd9lIzj08aD4qSLpgDEKWV0=; b=Ia4wLLkGoYkp7GA0nujP0c3wHG 7IydRhN+bTm27ieArsiJBjwCu6FTkaiS3hz2vhJnSwYi9yf5n2XgAExHBuNTgYVtxVgexVL1669bR GwCAV8r255PDGSvT5sEdDQuyw; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:38490 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1ff6Xt-000PpC-Ph; Mon, 16 Jul 2018 11:40:21 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 12/13] Add ATTRIBUTE_UNUSED to regdat.sh output References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-13-tom@tromey.com> <9c6ed571-1f28-f527-64ff-445f51089dcd@redhat.com> Date: Mon, 16 Jul 2018 16:41:00 -0000 In-Reply-To: <9c6ed571-1f28-f527-64ff-445f51089dcd@redhat.com> (Pedro Alves's message of "Mon, 16 Jul 2018 16:11:43 +0100") Message-ID: <87r2k35e2z.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2018-07/txt/msg00494.txt.bz2 >>>>> "Pedro" =3D=3D Pedro Alves writes: Pedro> On 07/12/2018 09:52 PM, Tom Tromey wrote: >> This changes regdat.sh to emit ATTRIBUTE_UNUSED for the >> xmltarget_${name} variable. This seemed simpler than trying to figure >> out under exactly which circumstances each one was in fact used. Pedro> Can you give an example configuration where you got a warning? I only found this one via the buildbot: https://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/9085 It fails like so: s390-linux32-generated.c: In function =E2=80=98void init_registers_s390_lin= ux32()=E2=80=99: s390-linux32-generated.c:141:20: error: unused variable =E2=80=98xmltarget_= s390_linux32=E2=80=99 [-Werror=3Dunused-variable] static const char *xmltarget_s390_linux32 =3D "s390-linux32.xml"; ^~~~~~~~~~~~~~~~~~~~~~ s390-linux32v1-generated.c: In function =E2=80=98void init_registers_s390_l= inux32v1()=E2=80=99: s390-linux32v1-generated.c:143:20: error: unused variable =E2=80=98xmltarge= t_s390_linux32v1=E2=80=99 [-Werror=3Dunused-variable] static const char *xmltarget_s390_linux32v1 =3D "s390-linux32v1.xml"; ^~~~~~~~~~~~~~~~~~~~~~~~ s390-linux32-generated.c: At global scope: s390-linux32-generated.c:141:20: error: =E2=80=98xmltarget_s390_linux32=E2= =80=99 defined but not used [-Werror=3Dunused-variable] s390-linux32v1-generated.c: At global scope: s390-linux32v1-generated.c:143:20: error: =E2=80=98xmltarget_s390_linux32v1= =E2=80=99 defined but not used [-Werror=3Dunused-variable] Tom