From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41755 invoked by alias); 4 May 2018 15:41:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41695 invoked by uid 89); 4 May 2018 15:41:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.147.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 May 2018 15:41:46 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 912311B6FD for ; Fri, 4 May 2018 10:41:44 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Ecq8fUohN6il3Ecq8fSU1e; Fri, 04 May 2018 10:41:44 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:45406 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fEcq8-002EgU-8C; Fri, 04 May 2018 10:41:44 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Move core_bfd to program space References: <20180503162234.15371-1-palves@redhat.com> <20180503162234.15371-2-palves@redhat.com> Date: Fri, 04 May 2018 15:41:00 -0000 In-Reply-To: <20180503162234.15371-2-palves@redhat.com> (Pedro Alves's message of "Thu, 3 May 2018 17:22:32 +0100") Message-ID: <87r2mr2zt4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fEcq8-002EgU-8C X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:45406 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00091.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> This moves the core_bfd global to be a field of the program space. It Pedro> then replaces core_bfd with a macro to avoid a massive patch -- the Pedro> same approach taken for various other program space fields. I am curious to know whether you would want to remove this macro in the future. I don't mean that you should do it -- just more a question of what direction to go. There are other macros like this too: symfile_objfile, object_files, exec_bfd, ... Also, I can't remember why I moved core_bfd to the progspace. Would it be better to have it just be a member of the target? Or maybe in your design these end up being basically equivalent, because core targets are inherently single-process? Tom