From: Tom Tromey <tom@tromey.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: possible fix for PR symtab/23010
Date: Thu, 19 Apr 2018 20:39:00 -0000 [thread overview]
Message-ID: <87r2nb7wxo.fsf@tromey.com> (raw)
In-Reply-To: <f163fa84-eb60-ac12-dedb-b6970b799165@redhat.com> (Keith Seitz's message of "Tue, 17 Apr 2018 12:17:00 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> I tried for darn near a week to come up with an isolated
Keith> reproducer to no avail. :-(
If you have a test case, could you send it, even it if doesn't work?
I could try to poke at it a little.
Keith> Aside: didn't we decide that "update all callers" was sufficient? [I'm
Keith> only curious -- not asking for changes to a silly ChangeLog.]
Yeah, old habits I guess.
Keith> This patch looks reasonable to me, but I would ask you to consider
Keith> mentioning why partial_units are skipped where they are (even if to
Keith> just reference the problem or bug?). That's these two hunks, I think:
Good idea, will do.
Tom
next prev parent reply other threads:[~2018-04-19 20:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 19:06 Tom Tromey
2018-04-17 19:17 ` Keith Seitz
2018-04-19 20:39 ` Tom Tromey [this message]
2018-04-30 22:44 ` Joel Brobecker
2018-05-07 17:13 ` Joel Brobecker
2018-05-14 19:43 ` Joel Brobecker
2018-05-18 1:22 ` Sergio Durigan Junior
2018-05-24 4:08 ` Tom Tromey
2018-05-24 10:50 ` Sergio Durigan Junior
2018-05-24 10:50 ` Tom Tromey
2018-05-24 15:54 ` Keith Seitz
2018-05-26 0:24 ` Keith Seitz
2018-05-27 15:20 ` Tom Tromey
2018-05-30 22:26 ` Joel Brobecker
2018-05-17 17:16 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2nb7wxo.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).