From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94659 invoked by alias); 19 Apr 2018 20:39:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94647 invoked by uid 89); 19 Apr 2018 20:39:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=avail, keiths@redhat.com, Keith, sk:keiths@ X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Apr 2018 20:39:33 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 6A83DC0641 for ; Thu, 19 Apr 2018 15:39:32 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9GL6fRAQ2WCOC9GL6fMji5; Thu, 19 Apr 2018 15:39:32 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:43132 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1f9GL6-004FaR-6r; Thu, 19 Apr 2018 15:39:32 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: possible fix for PR symtab/23010 References: <87po34kzxh.fsf@tromey.com> Date: Thu, 19 Apr 2018 20:39:00 -0000 In-Reply-To: (Keith Seitz's message of "Tue, 17 Apr 2018 12:17:00 -0700") Message-ID: <87r2nb7wxo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1f9GL6-004FaR-6r X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:43132 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00393.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> I tried for darn near a week to come up with an isolated Keith> reproducer to no avail. :-( If you have a test case, could you send it, even it if doesn't work? I could try to poke at it a little. Keith> Aside: didn't we decide that "update all callers" was sufficient? [I'm Keith> only curious -- not asking for changes to a silly ChangeLog.] Yeah, old habits I guess. Keith> This patch looks reasonable to me, but I would ask you to consider Keith> mentioning why partial_units are skipped where they are (even if to Keith> just reference the problem or bug?). That's these two hunks, I think: Good idea, will do. Tom