From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20842 invoked by alias); 4 Dec 2017 16:47:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20832 invoked by uid 89); 4 Dec 2017 16:47:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Dec 2017 16:47:53 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 38206C0467C4; Mon, 4 Dec 2017 16:47:52 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0EC04600CC; Mon, 4 Dec 2017 16:47:51 +0000 (UTC) From: Sergio Durigan Junior To: Eli Zaretskii Cc: gdb-patches@sourceware.org, tom@tromey.com Subject: Re: [PATCH v2] Implement pahole-like 'ptype /o' option References: <20171121160709.23248-1-sergiodj@redhat.com> <20171128212137.15655-1-sergiodj@redhat.com> <871ska7cx9.fsf@redhat.com> <83zi6yy00h.fsf@gnu.org> Date: Mon, 04 Dec 2017 16:47:00 -0000 In-Reply-To: <83zi6yy00h.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 04 Dec 2017 17:40:30 +0200") Message-ID: <87r2sa5tjc.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00083.txt.bz2 On Monday, December 04 2017, Eli Zaretskii wrote: >> From: Sergio Durigan Junior >> Cc: Tom Tromey , Eli Zaretskii >> Date: Mon, 04 Dec 2017 10:03:46 -0500 >> >> On Tuesday, November 28 2017, I wrote: >> >> > Changes from v1: >> > >> > - Address Tom's comments (the command now prints offset information >> > about unions, and the offset info is carried on for nested structs). >> > >> > - Address Eli's comments. >> > >> > - Extended testcase. >> > >> > - A "bit" of cleanup on 'c_type_print_base'. >> >> Ping. > > I believe I already approved the documentation parts. Right? Sorry, yes Eli, you have approved the docs already. Now I just need someone to look at the code ;-). Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/