From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65455 invoked by alias); 14 Oct 2016 21:30:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65391 invoked by uid 89); 14 Oct 2016 21:30:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*RU:sk:gproxy1, Hx-spam-relays-external:cmgw3, Hx-spam-relays-external:10.0.90.84, H*RU:10.0.90.84 X-HELO: gproxy1.mail.unifiedlayer.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO gproxy1.mail.unifiedlayer.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Oct 2016 21:29:52 +0000 Received: from cmgw3 (cmgw4 [10.0.90.84]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id C7023175C06 for ; Fri, 14 Oct 2016 15:29:50 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id vZVn1t00r2f2jeq01ZVq0P; Fri, 14 Oct 2016 15:29:50 -0600 X-Authority-Analysis: v=2.1 cv=KLfJUj1o c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=yRPbR3xMaNHVSyFFfFsA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:35748 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bvA31-00038l-HT; Fri, 14 Oct 2016 15:29:47 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 12/17] Remove make_cleanup_restore_current_uiout References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-13-git-send-email-tom@tromey.com> Date: Fri, 14 Oct 2016 21:30:00 -0000 In-Reply-To: (Pedro Alves's message of "Thu, 13 Oct 2016 23:49:27 +0100") Message-ID: <87r37iliuw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bvA31-00038l-HT X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya) [174.16.143.211]:35748 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00463.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I wonder if you had a reasoning that led to deciding when Pedro> to use two-argument form? A couple places looked like obvious Pedro> candidates. My reasoning would be: if the assignment is right Pedro> after the scoped_restore creation. I tried to use them everywhere, but I just forgot to restore it in this patch when I added the two-arg form back. I'll fix this up. Tom