From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118939-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23413 invoked by alias); 11 Jan 2015 13:58:04 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 23399 invoked by uid 89); 11 Jan 2015 13:58:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 11 Jan 2015 13:58:00 +0000
Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41])	by relay1.mentorg.com with esmtp 	id 1YAJ1g-0007lO-Qk from Yao_Qi@mentor.com ; Sun, 11 Jan 2015 05:57:56 -0800
Received: from GreenOnly (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.224.2; Sun, 11 Jan 2015 05:57:56 -0800
From: Yao Qi <yao@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
CC: <gdb-patches@sourceware.org>, Sasha Smundak <asmundak@google.com>
Subject: Re: [testsuite patch] Fix new FAIL: py-frame.exp: test Frame.read_register(rip)
References: <20150107143820.GA1482@host2.jankratochvil.net>
Date: Sun, 11 Jan 2015 13:58:00 -0000
In-Reply-To: <20150107143820.GA1482@host2.jankratochvil.net> (Jan Kratochvil's	message of "Wed, 7 Jan 2015 15:38:20 +0100")
Message-ID: <87r3v1s9ld.fsf@codesourcery.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00273.txt.bz2

Jan Kratochvil <jan.kratochvil@redhat.com> writes:

>  # On x86-64, PC is in $rip register.
> -if {[istarget x86_64-*]} {
> +if {[is_amd64_regs_target]} {
>      gdb_test "python print ('result =3D %s' % (f0.read_register('pc') =
=3D=3D f0.read_register('rip')))" \
>  	" =3D True" \
>  	"test Frame.read_register(rip)"

Hi, Jan,
With your patch applied, this test is skipped on 'x86_64 -m32'.  I
prefer to increasing the test coverage, so how about extending the test
for 'x86_64 -m32'?  I mean test Frame.read_register(eip)...

--=20
Yao (=E9=BD=90=E5=B0=A7)