Re: [PATCH 3/4] Create syscall groups for x86_64.

[Gabriel Krisman Bertazi <gabriel@krisman.be>]

[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]

Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio,

Thank you for your review.  I applied your suggestions and I will send
the updated patches to this list in a few moments.

> On Sunday, November 02 2014, Gabriel Krisman Bertazi wrote:
>
>> This commit introduces the following syscall groups for the x86_64
>> architecture: memory, ipc, process, descriptor, signal and file.
>>
>> Please note that the sorting of the syscalls among these several groups
>> follows the same structure used in strace.
>>
>> This also introduces tests for catching groups of syscalls on the x86_64
>> architecture.
>
> I guess I said that before, but just in case I didn't: I would prefer if
> this patch already updated the other architectures as well.  IIUC you
> are planning to do that in another series of patches, but it would be
> good if you did everything at once, I think.  However, I will not oppose
> if you decide to touch only on x86_64 for now.

Updating the syscall files by hand is quite error-prone and requires
lots of typing.  Should we bring PR 14276 to the table, it would also
require extra work to update the groups later.

A few weeks ago, you and I talked about writing a script to fix PR14276.
What I want to do is to save me some typing now and update the other
architectures only after we have such script to generate the syscall
files, so we can use it to also generate the group information
automatically.  What do you think? Is that ok for you?

-- 
Gabriel Krisman Bertazi

[-- Attachment #2: Type: application/pgp-signature, Size: 818 bytes --]