From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8189 invoked by alias); 8 Sep 2014 18:59:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8178 invoked by uid 89); 8 Sep 2014 18:59:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 08 Sep 2014 18:59:43 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s88IxdOM023616 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 8 Sep 2014 14:59:39 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s88IxcXi013341 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 8 Sep 2014 14:59:38 -0400 From: Sergio Durigan Junior To: Pedro Alves Cc: Adrian Sendroiu , tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/2] mi-out: Implement mi redirection using a stack. References: <53D8DA80.8010603@redhat.com> <1406819332-24242-1-git-send-email-adrian.sendroiu@freescale.com> <53DA6D73.5050906@redhat.com> <53E0E251.7040803@freescale.com> <540DACE2.9060400@redhat.com> X-URL: http://www.redhat.com Date: Mon, 08 Sep 2014 18:59:00 -0000 In-Reply-To: <540DACE2.9060400@redhat.com> (Pedro Alves's message of "Mon, 08 Sep 2014 14:19:30 +0100") Message-ID: <87r3zmsztx.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00204.txt.bz2 On Monday, September 08 2014, Pedro Alves wrote: >> + mi_expect_stop "breakpoint-hit" "do_nothing" ".*" ".*" ".*" {".*" ".*"} "Continue to breakpoint" >> + >> + # This will crash gdb if redirection is not done properly. >> + mi_gdb_test "help" ".*" "nested redirect" > > I think it'd be good to replace this ".*" with a stricter match, just > in case something goes wrong with undoing the redirection, but nothing > crashes. Something like (untested): > > mi_gdb_test "help" "List of classes of commands.*\\^done.*" "nested redirect" I've been seeing some cases like this in the list (i.e., writing tests using ".*" a lot). Maybe this is a good thing to mention in our wiki... -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/