Re: [PATCH 5/5] Fix for D demangling in GDB

[Tom Tromey <tromey@redhat.com>]

>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:

Iain> Couldn't find an easy way to move, then fix.  So I did fix, then move.

Thank you.

Iain> +/* Demangle the calling convention from MANGLE and append it to TEMPBUF.
Iain> +   Return the remaining string on success or NULL on failure.  */
Iain> +static const char *
Iain> +parse_call_convention (struct obstack *tempbuf, const char *mangle)

Blank line between comment and start of function; here and elsewhere.

Iain> +}
Iain> +
Iain>  static int
Iain> -extract_type_info (const char *mangled_str, struct obstack *tempbuf)
Iain> +call_convention_p (const char *mangle)
Iain>  {

Needs an intro comment.

Iain> +      if (mangle && call_convention_p (mangle))

We're trying to use the explicit checking form these days, so
"if (mangle != NULL && ..."

I didn't check the rest of the patch for this nit -- could you take a
look?


Other than the nits and the remaining test suite thing, this looks good.
Thanks again for splitting the patch.

Tom