From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-109097-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23366 invoked by alias); 10 Jan 2014 21:43:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 23353 invoked by uid 89); 10 Jan 2014 21:43:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2014 21:43:24 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0ALhLoM010801	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 10 Jan 2014 16:43:21 -0500
Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0ALhKH5006796	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 10 Jan 2014 16:43:20 -0500
From: Tom Tromey <tromey@redhat.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/5] Fix for D demangling in GDB
References: <CABOHX+fr7hyD0WM-=1G4zcoJH61uPiE9ezYSYmKuUoqvZnLmvA@mail.gmail.com>	<87zjn47ref.fsf@fleche.redhat.com>	<CABOHX+dXQQjpE2-S3wM5Qcrq=i29HewDzRptXcrn0=T+EVjOrg@mail.gmail.com>	<CABOHX+dKwZghfF=2KRD8Znj3B5s=knOAdX9VZKBH+8CVBAT1NA@mail.gmail.com>
Date: Fri, 10 Jan 2014 21:43:00 -0000
In-Reply-To: <CABOHX+dKwZghfF=2KRD8Znj3B5s=knOAdX9VZKBH+8CVBAT1NA@mail.gmail.com>	(Iain Buclaw's message of "Fri, 10 Jan 2014 14:51:50 +0000")
Message-ID: <87r48f4io8.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2014-01/txt/msg00299.txt.bz2

>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:

Iain> Couldn't find an easy way to move, then fix.  So I did fix, then move.

Thank you.

Iain> +/* Demangle the calling convention from MANGLE and append it to TEMPBUF.
Iain> +   Return the remaining string on success or NULL on failure.  */
Iain> +static const char *
Iain> +parse_call_convention (struct obstack *tempbuf, const char *mangle)

Blank line between comment and start of function; here and elsewhere.

Iain> +}
Iain> +
Iain>  static int
Iain> -extract_type_info (const char *mangled_str, struct obstack *tempbuf)
Iain> +call_convention_p (const char *mangle)
Iain>  {

Needs an intro comment.

Iain> +      if (mangle && call_convention_p (mangle))

We're trying to use the explicit checking form these days, so
"if (mangle != NULL && ..."

I didn't check the rest of the patch for this nit -- could you take a
look?


Other than the nits and the remaining test suite thing, this looks good.
Thanks again for splitting the patch.

Tom