[PATCH][commit/obvious] Fix argument type on gdbsim_detach prototype.

[PATCH][commit/obvious] Fix argument type on gdbsim_detach prototype.

[Edjunior Barbosa Machado]

Hi,
gdb ppc64 build was failing with the following:

gcc -g3 -mminimal-toc  -I. -I../../gdb -I../../gdb/common -I../../gdb/config -DLOCALEDIR="\"/usr/share/locale\"" -DHAVE_CONFIG_H -I../../gdb/../include/opcode -I../../gdb/../opcodes/.. -I../../gdb/../readline/.. -I../bfd -I../../gdb/../bfd -I../../gdb/../include -I../libdecnumber -I../../gdb/../libdecnumber  -I../../gdb/gnulib/import -Ibuild-gnulib/import   -DTUI=1  -I/usr/include/python2.6 -I/usr/include/python2.6 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o remote-sim.o -MT remote-sim.o -MMD -MP -MF .deps/remote-sim.Tpo ../../gdb/remote-sim.c
../../gdb/remote-sim.c:820: error: conflicting types for ‘gdbsim_detach’
../../gdb/remote-sim.c:81: note: previous declaration of ‘gdbsim_detach’ was here
make[2]: *** [remote-sim.o] Error 1

I've checked in the obvious patch below that fixed the problem.
Thanks,

--
Edjunior

2013-11-11  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>

	* remote-sim.c (gdbsim_detach): Fix prototype.
---
 gdb/ChangeLog    |    4 ++++
 gdb/remote-sim.c |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c
index e095035..f7be6fa 100644
--- a/gdb/remote-sim.c
+++ b/gdb/remote-sim.c
@@ -78,7 +78,7 @@ static void gdbsim_open (char *args, int from_tty);
 
 static void gdbsim_close (void);
 
-static void gdbsim_detach (struct target_ops *ops, char *args, int from_tty);
+static void gdbsim_detach (struct target_ops *ops, const char *args, int from_tty);
 
 static void gdbsim_prepare_to_store (struct regcache *regcache);
 
-- 
1.7.1

Re: [PATCH][commit/obvious] Fix argument type on gdbsim_detach prototype.

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

> 2013-11-11  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
> 
> 	* remote-sim.c (gdbsim_detach): Fix prototype.

Thanks!

I just noticed that one line then became too long. So I pushed
a checkin of my own as well...

> -static void gdbsim_detach (struct target_ops *ops, char *args, int from_tty);
> +static void gdbsim_detach (struct target_ops *ops, const char *args, int from_tty);

gdb/ChangeLog:

        * remote-sim.c (gdbsim_detach): Break declaration into
        shorter lines.  No code change.

-- 
Joel

[-- Attachment #2: 0001-Minor-reformatting-in-remote-sim.c-gdbsim_detach-dec.patch --]
[-- Type: text/x-diff, Size: 1354 bytes --]

From 8ca5801b3a05240125a79cd5ba090c98dcc584f8 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Mon, 11 Nov 2013 18:13:40 +0400
Subject: [PATCH] Minor reformatting in remote-sim.c (gdbsim_detach
 declaration).

gdb/ChangeLog:

        * remote-sim.c (gdbsim_detach): Break declaration into
        shorter lines.  No code change.
---
 gdb/ChangeLog    | 5 +++++
 gdb/remote-sim.c | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5a0d355..a47c14e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2013-11-11  Joel Brobecker  <brobecker@adacore.com>
+
+	* remote-sim.c (gdbsim_detach): Break declaration into
+	shorter lines.  No code change.
+
 2013-11-11  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
 
 	* remote-sim.c (gdbsim_detach): Fix prototype.
diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c
index f7be6fa..6bf18ab 100644
--- a/gdb/remote-sim.c
+++ b/gdb/remote-sim.c
@@ -78,7 +78,8 @@ static void gdbsim_open (char *args, int from_tty);
 
 static void gdbsim_close (void);
 
-static void gdbsim_detach (struct target_ops *ops, const char *args, int from_tty);
+static void gdbsim_detach (struct target_ops *ops, const char *args,
+			   int from_tty);
 
 static void gdbsim_prepare_to_store (struct regcache *regcache);
 
-- 
1.8.1.2

Re: [PATCH][commit/obvious] Fix argument type on gdbsim_detach prototype.

[Tom Tromey]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> 2013-11-11  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
>> 
>> * remote-sim.c (gdbsim_detach): Fix prototype.

Joel> Thanks!

Thanks to you both.

Tom