Re: [PATCH 1/2] gdb: avoid '//' in filenames when searching for debuginfo

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> You're absolutely right.  And I see what's happened.  Somewhere along
Andrew> the line the logic has gotten reversed in my head.  The problem isn't
Andrew> that the first _must_ be absolute with path_join, it's that everything
Andrew> else _must_not_ be absolute, see these lines in path_join:

Andrew>       if (i > 0)
Andrew> 	gdb_assert (strlen (path) == 0 || !IS_ABSOLUTE_PATH (path));

Andrew> And for what we're doing here we, for example, join the path to the file
Andrew> (which is absolute) onto the debug directory, which might, or might not,
Andrew> be absolute, e.g. these lines in find_separate_debug_file:

I'm sorry to go around on this again, but what if we just remove this
restriction from path_join?  It seems to me that removing an assertion
can't break any existing callers, and it's fairly normal in other code
bases for path-joining to work this way (that is, an absolute path
causes a "start over").

Tom