From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 6DD2D3858D35 for ; Tue, 23 Apr 2024 03:30:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6DD2D3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6DD2D3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713843036; cv=none; b=xlEo+iMpJWiZkl0WnGcMsxbqZ6G03lZcHAbMnwL9l0wHh8Bj3oOiHERXI2FqgUuNOQVpvxZn0qgdppEX55dpClRnQY8vp913UGEaEmrwATCKY3gUJN13At2RzZ+1xLMsS1lqVBAXFFhfa5eUtaA/r5M1Yxnu3e4SUlGpDdhNNFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713843036; c=relaxed/simple; bh=W3Zje+YCT3l/Ch4qV0sKYORjVUD0dmUCMLtQh1TK6NM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=n2qbJ1LDEYy9GKM2GRfDvit0+hdtSHOJFE69BEzx5ijE4Fv8MwHa/01d6ARxBduLk84w/kWpO8V0di0xsr6PycZQrM1pE2ybTRB85UyY8ow4THZ7vG/XgxOKX6cWzB0oyNE63AiC6WwPTzgxuUT9qGIZWmS5Kd047PiQQJASBeo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6009a.ext.cloudfilter.net ([10.0.30.184]) by cmsmtp with ESMTPS id ylldresxhtf2Qz6rarOGoR; Tue, 23 Apr 2024 03:30:34 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id z6rZrxZlinNCOz6rarLxhm; Tue, 23 Apr 2024 03:30:34 +0000 X-Authority-Analysis: v=2.4 cv=DKCJ4TNb c=1 sm=1 tr=0 ts=66272b5a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=TkbOQ4GleDuWft90SPAA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FN46KaTFToNFLQVi3xuJ8+HdRrn3Dsn7JVxXWvLGo3M=; b=MZheTPtOv0f0xS6iIzPthjlVrg ScW4xCmd2z5VL4WiE5VsSKYDbF2paGL79msbWPcsENo4ry/Q0NYWwd0IFOAJkqmuXthQoaKKAu51k kf7QjsjFqgSj7SUAoFUgM/Eab; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:36754 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rz6rZ-000VPs-23; Mon, 22 Apr 2024 21:30:33 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [pushed] gdb: fix include for gdb_signal in target/waitstatus.h In-Reply-To: (Simon Marchi's message of "Mon, 22 Apr 2024 23:18:52 -0400") References: <20240419200856.2291305-1-simon.marchi@polymtl.ca> <87h6fxt86u.fsf@tromey.com> X-Attribution: Tom Date: Mon, 22 Apr 2024 21:30:32 -0600 Message-ID: <87sezceox3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1rz6rZ-000VPs-23 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (prentzel) [97.122.86.252]:36754 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJ4ogorubsFBLhwxMsFK7dUX/fGHH2oWMWE5QYMOdbBEhxe/RDfHAZQ2L5s2W+mEIMGgmjKBTJR+3eXb1iGIQiZEB2xs3g49SEFufsi+JuNN9NQ9HYhJ duTMgu69+bQPllCY800B0a4hzBpOBAUO1EZ70LaefBwcdt1qVUaAkYEAwQiiUP12GhMcyaB7ACVM2CSKV6CTpXuCv8v2oT4yEbs= X-Spam-Status: No, score=-3015.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon> +#include "gdb/signals.h" >> >> I think target/ files should not depend on files from gdb, because >> gdb/target (and gdb/nat) are also used by gdbserver. Simon> This is include/gdb/signals.h, not a header from the gdb directory. Thanks, that makes sense. >> IMO that's a confusing situation and we should probably move those >> subdirs to gdbsupport (but not build them there) to make the setup more >> clear. If that's possible. Simon> Agreed, I don't really like the current situation. If we moved to the only-gdbserver model we wouldn't have this problem :) But moving just the files to gdbsupport is easier and might help. Though it probably still won't help me remember the top-level include directory. Tom