From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Pedro Alves <pedro@palves.net>, Tom Tromey <tromey@adacore.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v4 0/4] Add include guard checker and reformatter
Date: Fri, 19 Apr 2024 14:52:47 -0600 [thread overview]
Message-ID: <87sezhrs68.fsf@tromey.com> (raw)
In-Reply-To: <35cc3c26-db4a-4594-9a21-9917bd7e41b3@simark.ca> (Simon Marchi's message of "Fri, 19 Apr 2024 14:43:56 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> On 2024-04-19 12:55, Pedro Alves wrote:
>> On 2024-04-19 16:26, Simon Marchi wrote:
>>> So, after patch 4/4, your script doesn't need to handle the the
>>> `defined(FOO_H)` style (OLDDEF in your script). I think you could
>>> remove support for that, it would simplify it a little bit.
>>
>> Doesn't it need to handle it in case someone creates a new header and writes
>> defined(FOO_H) manually? You'd still want the hook to fix that.
>>
Simon> IMO, after the initial run, the script doesn't really need to auto fix
Simon> things, it can just check and report errors.
I had it work that way initially, but it was irritating to know that the
script could do this for me without my intervention, since it had
already figured out exactly what to do.
Tom
next prev parent reply other threads:[~2024-04-19 20:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 15:03 Tom Tromey
2024-04-19 15:03 ` [PATCH v4 1/4] Fix some minor header file irregularities Tom Tromey
2024-04-19 15:03 ` [PATCH v4 2/4] Add an include-checking script Tom Tromey
2024-04-19 15:03 ` [PATCH v4 3/4] Add check-include-guards.py to pre-commit Tom Tromey
2024-04-19 15:03 ` [PATCH v4 4/4] Run check-include-guards.py Tom Tromey
2024-04-19 15:26 ` [PATCH v4 0/4] Add include guard checker and reformatter Simon Marchi
2024-04-19 16:55 ` Pedro Alves
2024-04-19 18:43 ` Simon Marchi
2024-04-19 20:52 ` Tom Tromey [this message]
2024-04-26 15:19 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sezhrs68.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).