From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D369C3858D1E for ; Tue, 19 Mar 2024 16:04:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D369C3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D369C3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710864293; cv=none; b=TYcYFLHzFDB/mWg8gcbLvX/EVo1ClBfzSmezaNboEs8m11gr10Sx2qYpjVpehYg78+VWfpHIlpQ48VXknNgcF6zyKobX5HEI/8RfiU5foyI6nh0NHhtcHG5wy+ZongunxgVb5RTvuN3yAgV4zxw15dAkTL94h6UM5U2zxFHuoHc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710864293; c=relaxed/simple; bh=F3nEpV4OEdRAbCp4mtCnaDIkUS6XJeSg2a9l0K7oatE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nDSR1w+LJFFQ5HSRPfr1E+fufmucrmM3Wmf+oMEn6s438GAzt84eoo1dt+2vO3xvJqlKhagZX8gKpX67mCM6l7tPlGXK2wieKTJmYNTvOxfiG7ZxpQ9sD20p/pTcTUyEXlP341l/h883FEA1J8DWJBb3mJEwOS5HzlJX7ipW528= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710864291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F3nEpV4OEdRAbCp4mtCnaDIkUS6XJeSg2a9l0K7oatE=; b=BlyPTeS/WC/QfL4wr5c6D9q/1AUBkV4EhLr7EBg9x5VwngXBVTGozkhvu6Q93s2l88BtFU y+lzwdki+GaL8XhBsj+Ch8H3cQ0tGgelqaIWwle5o81rwgvA4qo85KqJUtGzFZTAPb6mfc AfC0+TCx3bEkq7vO3Lu54SEWhLYdw7g= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-dqgeMaxCMn-CuTXjBylg1A-1; Tue, 19 Mar 2024 12:04:49 -0400 X-MC-Unique: dqgeMaxCMn-CuTXjBylg1A-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-56b8c7b5086so1114650a12.2 for ; Tue, 19 Mar 2024 09:04:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710864287; x=1711469087; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F3nEpV4OEdRAbCp4mtCnaDIkUS6XJeSg2a9l0K7oatE=; b=U50i1CrQyKFO5HCA8kKUkrft2KxUgGIiszdnCoJS4ufOhx4hNV9YhWYmKlkqrjBFRf Hs9iRcqzFBdpBWwrhyrAGmTeDjsdsa0rbSl2NUTI5/MCcKM6GLtsuy6lo9sFwLDaMn3O NrXyd2iX4CFCzlQdwlDW9vNG4F7AzG4FslpUQLVMAPc/ad6VqHj0I/EuvqLcu6dkwbjq o1IC5X3OTpTvuWfST8414SlnC7Nd9Rcr56PTmxQRE5Bi4m0thPmj/RRJycyN1gOTish/ uuHky6lTw0hbl6lZKEWqrR2qeAoBjR8gIcP8VAPG9gDP0OYBv08aWM0PY8yZqS+Zz5NB hRJw== X-Forwarded-Encrypted: i=1; AJvYcCUfLdNbf0VolYCcaQeyUXMKNiKfVi0t0tT36pdiw8F+nx8iQ22yllGip3JktRbeL/T7EqKQn8s4YNeIivYRXpwTs+Xa3WI1y+PuNg== X-Gm-Message-State: AOJu0YzH4dnvHydlajE7Z+JgWXwiA3F6ALxyswIUdUVMVS1juFq90XG8 8QxCw2mR9/HRGejjkXHe5Naiaap2yqQotey5iSaDw6LwNbpZMNe0BZQYeXPPGoef9HHwOMSAMY2 tOaa+ea1SNm0Q7BYSyiJSBBLi8OHws+pQTTPdgctHq9GqC/wnS9lPuHTc/ar2JhSW1jY= X-Received: by 2002:a50:cd87:0:b0:564:f6d5:f291 with SMTP id p7-20020a50cd87000000b00564f6d5f291mr10176996edi.34.1710864287305; Tue, 19 Mar 2024 09:04:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcYfF+7zbzoAf/+nSGDo9ol8b4m5dU79b3gQb2i/2BwOlYesWzqnv0Q6aPEdvyVNmshmWKmA== X-Received: by 2002:a50:cd87:0:b0:564:f6d5:f291 with SMTP id p7-20020a50cd87000000b00564f6d5f291mr10176981edi.34.1710864286748; Tue, 19 Mar 2024 09:04:46 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id cw26-20020a056402229a00b00568ba57983csm4172750edb.0.2024.03.19.09.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 09:04:45 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/python: test exception case for gdb.solib_name In-Reply-To: <87v85igqrg.fsf@tromey.com> References: <856ee4315d2d615388efe8352b29379feefa4054.1710503245.git.aburgess@redhat.com> <87msqzk540.fsf@tromey.com> <8734smv9w8.fsf@redhat.com> <87v85igqrg.fsf@tromey.com> Date: Tue, 19 Mar 2024 16:04:44 +0000 Message-ID: <87sf0mtdgj.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> I still think it's worth testing these cases though. > > Andrew> How about the patch below, there's no documentation changes, just adding > Andrew> a couple of additional tests. > > Seems fine to me. > Approved-By: Tom Tromey Pushed. Thanks, Andrew