From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 6AECA3858C39 for ; Wed, 13 Mar 2024 19:10:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6AECA3858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6AECA3858C39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710357006; cv=none; b=d6Y20/cwhBGbBs/73QBjz00D6JAEen5HN7TRIpFaZ/v1CQHcz4fnKJY8yiTIN1nBxyo0cg6DstP4wSF1IN51Bu9q0lOFwsclgLbcRwZuaFLKN1aUjd9S3Dckg7r+VJSZvCzXAQU/g6wukXOKE/RPyUPzHVamFAw0/R2mqOlnpaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710357006; c=relaxed/simple; bh=o6vLlTmsx/Ul4oGnjOhUIFNUi5w0b6eBVHjxXr0JGIs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rA7YfoBb+UfckHOpgJj5cAdzwKyANhklcUajVRVzRu5cPmPwVwz81e0J/d4HIad/3r0RyV3IIdUhv7NhajkE/KDudnKh2TEBYplGQMyKuYvshsz5N87nB8egdIHxgTO9uaUH/49GadeZl+L1osaqWE/pDgTw9yl1x+JxtsiWpA0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTPS id kRfVrySYAtf2QkTzGreFjd; Wed, 13 Mar 2024 19:10:03 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id kTzFrkzL4xdGokTzGrPkF4; Wed, 13 Mar 2024 19:10:02 +0000 X-Authority-Analysis: v=2.4 cv=WZUKaVhX c=1 sm=1 tr=0 ts=65f1fa0a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=QyXUC8HyAAAA:8 a=HhnPl3SUFbQ1Z-AVTkwA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8CuZ8Y5B0uTBZ/WwUg6lNARBH5f9f6iM/u4L72cK1MQ=; b=UnLe0uX2ZLhJrw1h+sCBFZ48t6 ceozucuzv2enNdgY6UUa45CGijBFJKunk66BxyFO+ijGqPG7GKzWyeoPlveyh3zcW1FNk6RtY3zGh QtMWoCgsKxmILRSXqeBed57tK; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:58098 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rkTzF-002jGa-1f; Wed, 13 Mar 2024 13:10:01 -0600 From: Tom Tromey To: Tankut Baris Aktemur Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] gdbserver: allow suppressing the next putpkt remote-debug log References: <44e58e5113d85284e5cd5bc33badd3ac55390dc2.1710343840.git.tankut.baris.aktemur@intel.com> X-Attribution: Tom Date: Wed, 13 Mar 2024 13:10:00 -0600 In-Reply-To: <44e58e5113d85284e5cd5bc33badd3ac55390dc2.1710343840.git.tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur's message of "Wed, 13 Mar 2024 16:35:43 +0100") Message-ID: <87sf0ulzhz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rkTzF-002jGa-1f X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:58098 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfK8wSv1qEvyoqQVDcMJXAExCAzCuJNx0OwspKkv9mApSTNTYOCdH3FYvn8axSUk+HCg07uewQsifCc2qNootWjZRDZXwv2INTjJ5/490+9vwURwwTKkU 6c2lV+dcFMOzSd2cMog/8UGF62Ii3otl4NpWRB4zVDn6Nu0aj5u0OhNRKoS074Vhhm+bdRrqWWXnD1JTy2Z7aTolWUatwRsNOAo= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Tankut Baris Aktemur writes: > When started with the --remote-debug flag, gdbserver enables the debug > logs for the received and sent remote packets. If the packet contents > are too long or contain verbatim binary data, printing the contents > may create noise in the logs or even distortion in the terminal output. I'm sort of meh about this patch. However, there are already other ways to get more complete logs (my fave is "set remotelogfile", since that can be replayed), so I guess the concept is alright. > +void > +suppress_next_putpkt_log () > +{ > + suppressed_remote_debug = true; > +} I think returning a scoped_restore here would be better. Or just letting clients do this directly. > + SCOPE_EXIT { suppressed_remote_debug = false; }; Then you wouldn't need a SCOPE_EXIT here. Tom