From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id ACFAA3858407 for ; Tue, 9 Jan 2024 19:12:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACFAA3858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ACFAA3858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704827526; cv=none; b=PTnrzBfUxMmdxWcD9RXHZmZ2GqoQzHmF3uWgQIieDNDBFCKu9SakXBddUxCppe9/D2qDkJvR6VIJukCuDNFyc1AwpGNllzYofmJzKG99YOs75t1DaAxF5BTS+CcXx75uNfu5xomw1OnasKt+cLA2F+5FSAwyKhbXzJLcTjb7Q6A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704827526; c=relaxed/simple; bh=AXGwv0r9U0y0TE+oLQhoQHrFFS3tmdp+h+vgkj93su8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Q+vpE0FDpG1njwma/wR4RF5b7m0WYILmfYXrlYUzsf2HE4d4IlOVTZzGYyLW/FtuA/UrBeOF8RcUsHQXEB+vYXxVppHUq4r6V5znWsrrwtJjpZT8r3qIfXE8/pzDzABUmtbCx6h/+4Xd+bz47WObqUsGzXNXkIK4FggINZ/Wv5M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5006a.ext.cloudfilter.net ([10.0.29.179]) by cmsmtp with ESMTPS id NGk4rIEP1AxAkNHWMr4O4k; Tue, 09 Jan 2024 19:12:18 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id NHW7rcesLim6ENHW7rgML8; Tue, 09 Jan 2024 19:12:03 +0000 X-Authority-Analysis: v=2.4 cv=Qft1A+Xv c=1 sm=1 tr=0 ts=659d9a83 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=dzWzf_mpAAAA:8 a=rxqkMe-UAAAA:8 a=wCWlrrL2VzSUJIBfTl8A:9 a=5AUvQ4PPY60A:10 a=b4DR9a7p2ZdsqdHBznES:22 a=-RepjN8xdm5FDBkp6JAK:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cgt6+Gq0n6O3ssrozu5ooBzwsz5X+sUIUfb3Xlaoycc=; b=VSseXmAcioPzwd1NCBq8HkLSm+ l8os2DzS82HPYtRjjegedsNhLq0I9ZykJWDsfiiMEVv7ampBxKmImIX5zHcTJyj0h7QJnjm/Emvpo BwOzUK/cpj2tTLNaZg2NcV09y; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:57340 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rNHW7-0023Co-01; Tue, 09 Jan 2024 12:12:03 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v4 01/19] Don't use objfile::intern in DWO code References: <20231210-t-bg-dwarf-reading-v4-0-b978c32fd12f@tromey.com> <20231210-t-bg-dwarf-reading-v4-1-b978c32fd12f@tromey.com> <3bd8cf85-b429-4f5b-8952-58d4c1b585eb@simark.ca> X-Attribution: Tom Date: Tue, 09 Jan 2024 12:12:02 -0700 In-Reply-To: <3bd8cf85-b429-4f5b-8952-58d4c1b585eb@simark.ca> (Simon Marchi's message of "Tue, 9 Jan 2024 13:44:59 -0500") Message-ID: <87sf36tj7h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rNHW7-0023Co-01 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:57340 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfE/4kfoASGO1PSVDeJfTT8Ore1wtDw101LbgXPrhzOEnh6UN+gNz+xe/jUCPCVO7k0Wsq8//SS1KH2hPOlEjkduYnFhK6NGmlLVtOGYO9DXspq9JvpbC VxWLGjCWO+hbt7oRYwNdZ1g6LvVTzVOk9/3FIF801uOLQf3CJaOZHRuFGM3OGnla+R43ppAHxdWwIM3mbHDf1Hc9lDstYo5PssA= X-Spam-Status: No, score=-3016.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> On 12/10/23 16:41, Tom Tromey wrote: >> The DWO code in the DWARF reader currently uses objfile::intern. This >> accesses a shared data structure and so would be racy when used from >> multiple threads. I don't believe this can happen right now, but >> background reading could provoke this, and in any case it's better to >> avoid this, just to be sure. >> >> This patch changes this code to just use a std::string. A new type is >> introduced to do hash table lookups, to avoid unnecessary copies. Simon> Hi Tom, Simon> I am getting some ASan-related failures on my CI, starting with this Simon> patch. I had trouble reproducing on my machine, but I got it to Simon> reproduce when using the exact source and build paths that my CI job Simon> used (since the patch is related to how strings (including paths) are Simon> handled, it's possible that the bug requires some specific strings in Simon> order to show up). Sorry about that. I will try to investigate. It's probably this though: https://bholley.net/blog/2015/must-be-this-tall-to-write-multi-threaded-code.html Tom