From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 9527E38582AF for ; Fri, 15 Dec 2023 19:46:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9527E38582AF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9527E38582AF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702669585; cv=none; b=pMiUkNDfaIR/ztmEPz2O2+sm2QdPFhv4Tl+AhAHS/7VqxTw9nq0XpxMBXHtIoPF2H5hAYvYbySLntj/zhFB49HorHgedmxOSafCUCPXWcD2kM/T7u4tzIcMbhPhzJa4607ritCVGApOsub3+ka3s4LZEdrq//kKhlYvpTRphFkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702669585; c=relaxed/simple; bh=6GhB0REDFGdkbXk12i9lc2Ua3xVls84C9KUJ2sAFNBg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rgSeOLNd/5xzVT4W3mhoVrQQ9aCoDqwP8AsbakAXdYX8rU1UY3TVCdf2GKkYyeVTMPoRNts8OthykMPKDLmPHiMQoWny1UIvSbQMcBEaREhdbI4Fk1/otiFItcGhJPx2Q6g6cG+yCtW2y+tuNTAu8KF+TA8QQD+1IyhQ/Q+Hd2s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5010a.ext.cloudfilter.net ([10.0.29.199]) by cmsmtp with ESMTPS id E2B1rT7lJ8HteEE8crxX60; Fri, 15 Dec 2023 19:46:22 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id EE8brQfOphDnyEE8crJ3A9; Fri, 15 Dec 2023 19:46:22 +0000 X-Authority-Analysis: v=2.4 cv=fda+dmcF c=1 sm=1 tr=0 ts=657cad0e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yL4B/3firU3KbHaQ1X4kqumCxUSgG72h2P1u30biTpI=; b=HOq8Ulzs3Cv6H/f+WzriE5AmJZ bePGrrCiiLnXP73gHSWnSVIlngxKiZqK3RWbRQuTJiePQXnKAL9rZ0kC3BYNXlQ6svRt/+jcUc7D9 CbuNu9IzCiLHkj/s+oRaDLfuO; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:56466 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rEE8b-003WTm-1H; Fri, 15 Dec 2023 12:46:21 -0700 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom Tromey , Tom de Vries Subject: Re: [PATCH] [gdb/build] Remove dependency on _rl_term_autowrap References: <20230430110647.975-1-tdevries@suse.de> <878re9mbb2.fsf@tromey.com> X-Attribution: Tom Date: Fri, 15 Dec 2023 12:46:20 -0700 In-Reply-To: (Tom de Vries via Gdb-patches's message of "Mon, 1 May 2023 09:45:12 +0200") Message-ID: <87sf435jw3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rEE8b-003WTm-1H X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:56466 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJB2vWbVBupFFL73VtQVC1B0ckuaZTyiz9j6kInrWX3Sh3rQ/SabgSXYVqK4KJKdFWAVu9jVFBRkYhovMosnpU7dzMjOD7uIJQow4AVPG3Y9t6JKlJUt AhebK4HCyoRUKFlstI6d2YAQJXZtCsUsPrmPneMoheSIwQUhqy5rr+hYHNqeWKfR05qsSehF3OYjfYHMkjeI8lY0Ix859t87rUA= X-Spam-Status: No, score=-3016.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: >> However, I don't see another way to do it. Tom> I had an earlier version of the patch that used the COLUMNS env Tom> variable instead. It felt a bit hacky, so I went for Tom> _rl_term_autowrap, but patch attached below goes back to the COLUMNS Tom> approach. WDYT? Looks good to me. Maybe one nit: Tom> + char *columns_env_str = getenv ("COLUMNS"); ... mildly better to write "const char *" here. Tom