From: Tom Tromey <tom@tromey.com>
To: "Alexandra Hájková" <ahajkova@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb/python: avoid use of _PyOS_ReadlineTState
Date: Fri, 08 Dec 2023 11:04:58 -0700 [thread overview]
Message-ID: <87sf4cfu45.fsf@tromey.com> (raw)
In-Reply-To: <20231207110240.1853760-2-ahajkova@redhat.com> ("Alexandra =?utf-8?B?SMOhamtvdsOhIidz?= message of "Thu, 7 Dec 2023 12:02:40 +0100")
>>>>> "Alexandra" == Alexandra Hájková <ahajkova@redhat.com> writes:
Alexandra> Instead of using _PyOS_ReadlineTState, I propose that we switch to
Alexandra> calling PyGILState_Ensure() and PyGILState_Release(). These functions
Alexandra> will acquire the GIL based on the current thread. I think this should
Alexandra> be sufficient; I can't imagine why we'd be running
Alexandra> gdbpy_readline_wrapper on one thread on behalf of a different Python
Alexandra> thread.... that would be unexpected I think.
Makes sense to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-12-08 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 11:02 [PATCH 1/2] gdb: move gdbpy_gil into python-internal.h Alexandra Hájková
2023-12-07 11:02 ` [PATCH 2/2] gdb/python: avoid use of _PyOS_ReadlineTState Alexandra Hájková
2023-12-08 18:04 ` Tom Tromey [this message]
2023-12-08 18:04 ` [PATCH 1/2] gdb: move gdbpy_gil into python-internal.h Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf4cfu45.fsf@tromey.com \
--to=tom@tromey.com \
--cc=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).