From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id D1CD73858C41 for ; Mon, 4 Dec 2023 18:46:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1CD73858C41 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D1CD73858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701715567; cv=none; b=C1BL7OZCrPgoUgZgl9zMWje48YPuEsZZaZQyLWSWs/GByTEbihmVhaQsRRcyYcH7Dt/HJ8li1W0Bl+cBkT6AnYIPandSmUbNYiEaa91VnTCc5AVtA4etoFOsxr3jxEDz5WfqtFPdV6TtstlzQCHNKOVDC1oVCfGQdhNp6yALTSU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701715567; c=relaxed/simple; bh=Odob4n1piscHaH3z5UpVQU+mvL76qWqaE7l5m76hsw4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FepKmo1WIogrEprdtMtbAcAhH/fi/a5XlQGAG5d0X3If0GKHQS+MMMMWuQxV5jH6sdrNJFKa2o6RZstbkfrxvW0taTwsDK5nLHLc3HlTka41yAGVousVH25P8cG/ryvJX48sbH6GJwR881P8Knx/R+LOAIxTVxYxo+9cmtmLP9U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5002a.ext.cloudfilter.net ([10.0.29.215]) by cmsmtp with ESMTPS id AC91rdmOvjtZ3ADxNrXLa5; Mon, 04 Dec 2023 18:46:13 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id ADxFrWea0RQmiADxGr3I1q; Mon, 04 Dec 2023 18:46:06 +0000 X-Authority-Analysis: v=2.4 cv=CdcbWZnl c=1 sm=1 tr=0 ts=656e1e6e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=j2PIVHs4YZm5IxTK5xQA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=v2iCsHZqNONV+QqiBpe9oGbx8iTR/3GDCsSF+6NKrns=; b=J5PLkCV+z3yYQOYaNzWA1/LqAo /CjNzmp0IolMV7BnmPFsxFQTXxuMmdOuPwQQysFhR3zbPcNUjMHWYbbJH2rCNysBr/TCAon+Cy8n/ 0on1pUcnsV+F6kUzEp5SQz44A; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:51716 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rADxF-001E7C-2M; Mon, 04 Dec 2023 11:46:05 -0700 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix off-by-one error in compute_delayed_physnames References: <20231123053132.608835-1-tom@tromey.com> X-Attribution: Tom Date: Mon, 04 Dec 2023 11:46:05 -0700 In-Reply-To: <20231123053132.608835-1-tom@tromey.com> (Tom Tromey's message of "Wed, 22 Nov 2023 22:31:32 -0700") Message-ID: <87sf4hajrm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1rADxF-001E7C-2M X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:51716 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJ6pw8hbc6AAiCkKq24EXdGNlQE46rjqSf/cD1mZdWMEg8vngv0U0AEj/O1sVx8qce785LRDGTk90kAMoN2aDZAgBgrvm8ibqa++9iqBTtn5c/rAEQac W9466xyDyCjEZSlfBG9OXt0e6nSTQ5VVy62ZaWPt3gq1xIWu6y3GK8VPldNLw9GZKlyhVkYCAp2+U+79d6hjSnc0FQjyxpABajE= X-Spam-Status: No, score=-3017.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> compute_delayed_physnames does this: Tom> size_t len = strlen (physname); Tom> ... Tom> if (physname[len] == ')') /* shortcut */ Tom> break; Tom> However, physname[len] will always be \0. Tom> This patch changes it to the correct len-1. This is fairly trivial; I'm going to check it in now. Tom