public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: fix reopen_exec_file for files with target: prefix
Date: Fri, 27 Oct 2023 12:39:01 -0600	[thread overview]
Message-ID: <87sf5vlxkq.fsf@tromey.com> (raw)
In-Reply-To: <8f5ded0b6bac82dcc59fc028aad239012f08bf1a.1698246342.git.aburgess@redhat.com> (Andrew Burgess's message of "Wed, 25 Oct 2023 16:08:18 +0100")

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> @@ -105,21 +105,24 @@ specify_exec_file_hook (void (*hook) (const char *))
Andrew>  void
Andrew>  reopen_exec_file (void)
Andrew>  {
Andrew> -  int res;
Andrew> -  struct stat st;
Andrew> -
Andrew>    /* Don't do anything if there isn't an exec file.  */
Andrew>    if (current_program_space->exec_bfd () == NULL)
Andrew>      return;
 
Andrew> +  bfd *exec_bfd = current_program_space->exec_bfd ();

IMO you might as well hoist this a few lines up and use the local in
the NULL check as well.

Otherwise I think this looks good.  Thank you for doing this.

Tom

  reply	other threads:[~2023-10-27 18:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25 15:08 [PATCH 0/2] BFD cache management And Exec file " Andrew Burgess
2023-10-25 15:08 ` [PATCH 1/2] gdb: move all bfd_cache_close_all calls in gdb_bfd.c Andrew Burgess
2023-10-26  9:06   ` Lancelot SIX
2023-10-27  8:49     ` Andrew Burgess
2023-10-27 19:30   ` Tom Tromey
2023-10-30 10:20     ` Andrew Burgess
2023-10-31 18:28       ` Tom Tromey
2023-11-01 10:46         ` Andrew Burgess
2023-11-12 23:38           ` Tom Tromey
2023-10-25 15:08 ` [PATCH 2/2] gdb: fix reopen_exec_file for files with target: prefix Andrew Burgess
2023-10-27 18:39   ` Tom Tromey [this message]
2023-10-30 13:41 ` [PATCH 0/2] BFD cache management And Exec file " Andrew Burgess
2023-10-30 13:41   ` [PATCH 1/2] gdb: move all bfd_cache_close_all calls in gdb_bfd.c Andrew Burgess
2023-10-30 13:41   ` [PATCH 2/2] gdb: fix reopen_exec_file for files with target: prefix Andrew Burgess
2023-11-12 23:40   ` [PATCH 0/2] BFD cache management And Exec file " Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf5vlxkq.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).