Re: [PATCH v2] gdb/configure.ac: Add option --with-additional-debug-dirs

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Hello Eli,

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Sat, 07 Oct 2023 10:01:52 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: gdb-patches@sourceware.org, tom@tromey.com
>> X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
>>  DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS,
>>  TXREP autolearn=ham autolearn_force=no version=3.4.6
>> 
>> > From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
>> > Cc: gdb-patches@sourceware.org, tom@tromey.com
>> > Date: Thu, 05 Oct 2023 20:12:17 -0300
>> > 
>> > As a workaround, I was able to get away with some escaping:
>> > 
>> > $ ~/src/binutils-gdb/configure \
>> >     --disable-{binutils,ld,gold,gas,sim,gprof,gprofng} \
>> >     --with-auto-load-dir='foo\\\;bar\\\;baz' && make
>> >     ⋮
>> > checking for default auto-load directory... foo\\\;bar\\\;baz
>> > checking for default auto-load safe-path... foo\\\;bar\\\;baz
>> >     ⋮
>> > $ grep AUTO_LOAD gdb/config.h
>> > #define AUTO_LOAD_DIR "foo;bar;baz"
>> > #define AUTO_LOAD_SAFE_PATH "foo;bar;baz"
>> 
>> Thanks, will use these in my next build, and see if it works for me as
>> well.
>
> FTR: just tried this with the gdb-14.0.91 pretest, and it works just
> fine.  Thank you very much for helping me avoid this annoying problem
> (it previously required me to build GDB twice).

Excellent! I poked at it some more today and I noticed two things:

1. We provide the definition of AC_DEFINE_DIR ourselves in
   gdb/acinclude.m4, so what I said earlier about the fix having to be
   in Autoconf was wrong. Too bad, it's always a relief when the blame
   lies somewhere else. :-)

2. We can do the escape trick above automatically in gdb/configure.ac.

So I just sent a patch to do that:

https://inbox.sourceware.org/gdb-patches/20231026234013.937210-1-thiago.bauermann@linaro.org/

> I've updated the Bugzilla bug with this information.

Thanks. I will also update the bugzilla with my findings.

-- 
Thiago