From: Sam James <sam@gentoo.org>
To: Tom de Vries <tdevries@suse.de>
Cc: Sam James <sam@gentoo.org>, Tom Tromey <tom@tromey.com>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>,
Tom de Vries <vries@gcc.gnu.org>
Subject: Re: [PATCH] gdb: Fix an ODR warning with byacc with GDB_YY_REMAP
Date: Thu, 28 Sep 2023 03:56:42 +0100 [thread overview]
Message-ID: <87sf6zatsp.fsf@gentoo.org> (raw)
In-Reply-To: <8ed8360e-a553-49e9-93b1-a1ebcdaa52f6@suse.de>
Tom de Vries <tdevries@suse.de> writes:
> On 9/27/23 09:35, Sam James wrote:
>> Tom de Vries <tdevries@suse.de> writes:
>>
>>> On 9/26/23 15:48, Tom Tromey wrote:
>>>>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>>>> Tom> On 9/12/23 02:58, Sam James wrote:
>>>>>> - Tom commented that it probably constitutes obvious but while I
>>>>>> have binutils access, I'm not listed in gdb/MAINTAINERS for
>>>>>> write-after-approval, so I'm hesitant.
>>>> Tom> GDB write-after-approval requires a copyright assignment that
>>>> covers
>>>> Tom> gdb. Do you have a copyright assignment for gdb?
>>>> I think this patch could land without the paperwork, since it is
>>>> small.
>>>
>>> Agreed, which is why I've already approved it and asked Sam to commit it.
>>>
>>>> And, it would be good to get it in before GDB 14, since it is a build
>>>> fix.
>>>
>>> Agreed. Sam, is there anything preventing you from committing this?
>>> If so, then I can take care of it.
>> Sorry folks, done now - Tom's question had prompted me to go finally
>> figure out the copyright assignment bits and I got distracted.
>> Pushed!
>>
>
> Hi,
>
> thanks for pushing it.
>
> I saw you used a Copyright-paperwork-exempt tag, it's good to make
> that explicit (FWIW, I was not familiar with the tag itself, but I see
> there's prior usage).
>
> Just want to mention: my understanding is that this commit goes into
> the bucket legally insignificant contributions. If you keep adding
> similar commits, at some point this bucket will overflow and you need
> a copyright assignment to keep contributing regardless of the nature
> of the patch. I wish these things were less complicated ...
Thank you! I've just had the email from the FSF saying it's all done
(it was in-flight for a while but I needed to do some bits to finish it off).
I appreciate the nudge to get this done, it was overdue anyway and
I was putting it off.
Would you mind if I added myself to write-after-approval?
>
> Thanks,
> - Tom
best,
sam
next prev parent reply other threads:[~2023-09-28 2:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 0:58 Sam James
2023-09-12 10:49 ` Tom de Vries
2023-09-12 13:03 ` Tom de Vries
2023-09-26 13:48 ` Tom Tromey
2023-09-26 13:57 ` Tom de Vries
2023-09-27 7:35 ` Sam James
2023-09-27 7:52 ` Tom de Vries
2023-09-28 2:56 ` Sam James [this message]
2023-09-28 8:30 ` Tom de Vries
2023-09-29 4:37 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf6zatsp.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
--cc=tom@tromey.com \
--cc=vries@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).