From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta35.uswest2.a.cloudfilter.net (omta35.uswest2.a.cloudfilter.net [35.89.44.34]) by sourceware.org (Postfix) with ESMTPS id 0A4B13858409 for ; Wed, 16 Aug 2023 20:45:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A4B13858409 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-6010a.ext.cloudfilter.net ([10.0.30.248]) by cmsmtp with ESMTP id WNF4qY9fwEoVsWNOlqcrVV; Wed, 16 Aug 2023 20:45:47 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id WNOlqBddpKFbYWNOlqQhhG; Wed, 16 Aug 2023 20:45:47 +0000 X-Authority-Analysis: v=2.4 cv=N+s6qkxB c=1 sm=1 tr=0 ts=64dd357b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=Q8vyWaCtWOzzS40UPEsA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AEzpAWzSBX88ufAvBwhK+ApKeVlRoOCRzpJOBSfxo0s=; b=fWzW1MUaK1s5aZ21kuIEoyNckc zcZ/gEAph8Cgb+zlc+64yK1fHZfRV8nLwEbY8wstywX/0KV9XnLdZbyBeZBSQIfiTQDx7/IbGXlCp Lm6mPmZrRK9/R5HSlgEEftgBF; Received: from 75-166-142-177.hlrn.qwest.net ([75.166.142.177]:54130 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qWLFN-002c4H-1c; Wed, 16 Aug 2023 12:27:57 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH 0/7] [gdb/build] Fix -std=c++20 issues References: <20230815181309.8595-1-tdevries@suse.de> X-Attribution: Tom Date: Wed, 16 Aug 2023 12:27:56 -0600 In-Reply-To: <20230815181309.8595-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Tue, 15 Aug 2023 20:13:02 +0200") Message-ID: <87sf8iyh8z.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.142.177 X-Source-L: No X-Exim-ID: 1qWLFN-002c4H-1c X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-142-177.hlrn.qwest.net (murgatroyd) [75.166.142.177]:54130 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLS2U2qeP7WLQ8MsO4q1JYJTq4NeJ2KiHqMwz5VP4MY3YMIWwLeVt7y/NvujybyA/chHVYz1GRljJlFfbjbq5FYZX7HTpNQNrG5CIKyDBTrJ32bz6vdL yo4So8APuh9h3jtpWInsH62P7sB++WF6Y89D6UqeZKC7MFUpR41yYjxBfemBUTrENRM/976Vus4bweW9zADe2EMDzSFU8xrqHUM= X-Spam-Status: No, score=-3019.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_BL,RCVD_IN_MSPIKE_L3,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> I tried building gdb using -std=c++20, an ran into a few issues. Tom> This series contains fixes for most of them. Thanks for doing this. I read these & sent one comment. The rest look ok to me. Tom> But the other one, in remote_target::thread_info_to_thread_handle remains Tom> unfixed: Tom> ... Tom> gdb::byte_vector Tom> remote_target::thread_info_to_thread_handle (struct thread_info *tp) Tom> { Tom> remote_thread_info *priv = get_remote_thread_info (tp); Tom> return priv->thread_handle; First, I wonder if we even care about this copying. But if we do, it could return a const reference and linux-thread-db could be modified to cache the byte_vector in thread_db_thread_info. Tom