From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3BAF13858D20 for ; Fri, 11 Aug 2023 12:49:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BAF13858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691758166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zMuHDdid6zxbXqHmUS/+7KaF7PA0NB4gS78fIw+aQ+U=; b=eTkYfjViScuAmSBfGR2Oib/Hd+Tl1oJjkbjpaFlLIN1GAYalYX4vjTdzTa+IqLZPBMf8H5 +VIoh5B+dXNUprBwPv8/PjUOzWCWgCeVeen1ZxvOkZC+DhS6X7g7BzciVAw8HwhViROAza txk+DDU0sCmDCk0A2PA/FfwNmatmLD8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-35-LDLTBYADOwiE2RuDz3axKw-1; Fri, 11 Aug 2023 08:49:25 -0400 X-MC-Unique: LDLTBYADOwiE2RuDz3axKw-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3180a68fff0so1132917f8f.1 for ; Fri, 11 Aug 2023 05:49:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691758164; x=1692362964; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zMuHDdid6zxbXqHmUS/+7KaF7PA0NB4gS78fIw+aQ+U=; b=dBVzRaE+u8MKXOIlSk0meL/UabEAdD2iXG/u6USj/pNyDWg29lss8TOT5Ehbg3j+wn iDQ8U3+xiA96rkepTpkmPkudEbg9VEdfDq/orEtIQOP9kEqZN90qvPDJPaIqdmakMSch A8EfrBDMcAZVDjanvI6yCx0iK83kV0jm00IrGD0uP4W7tcVpfUIG7Yz+TiHCWYq8jjZ2 6ArcCqdklUei/HR0Efmk+uP4pi9NWAL+//77KnjqPcQ7zsLWkfGgjiAJU3glu04rCTIb 0YUTtAtWSbYm3qlrGdiaR+D7gCM0naBtljspuO9gUngDGgBIHmEi0frBh8JIw0HkdB55 a7jQ== X-Gm-Message-State: AOJu0YxqApqGMtR7uoSziOwiPwlWY889wz93PYll7WyFhZ6vI3DnslOR yBEETbUnDXFj96N8QYZo2yFILgQwD3mPBFJ8NbtYCfhoN0ooSBXWH3bfY88M4fdYJh2Q53NrjIp gfJiCyW25DgTMfZQNlPkEWg== X-Received: by 2002:a5d:5605:0:b0:314:77a:c2b2 with SMTP id l5-20020a5d5605000000b00314077ac2b2mr1066058wrv.32.1691758164348; Fri, 11 Aug 2023 05:49:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6T8fMhVcTuHuWkX94XgZXDG6jizSB1ZoP90S1VAIE/ksRr2jvncJKSQSQx8ETUlL35CQOmg== X-Received: by 2002:a5d:5605:0:b0:314:77a:c2b2 with SMTP id l5-20020a5d5605000000b00314077ac2b2mr1066048wrv.32.1691758163951; Fri, 11 Aug 2023 05:49:23 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id q4-20020adff944000000b003143c9beeaesm5347377wrr.44.2023.08.11.05.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 05:49:22 -0700 (PDT) From: Andrew Burgess To: Tsukasa OI , Palmer Dabbelt Cc: Tsukasa OI , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] RISC-V: Reflect actual range of vlen for hashing In-Reply-To: References: <4dfb6749640b5ffc2280468cddd4f378415f0118.1691745446.git.research_trasio@irq.a4lg.com> Date: Fri, 11 Aug 2023 13:49:21 +0100 Message-ID: <87sf8pd9ri.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tsukasa OI writes: > From: Tsukasa OI > > Before actual xlen handling, it fixes the hashing function based on the > actual valid range of xlen (xlen == 0 or 4 <= xlen <= 65536 / 8). Please reword the commit message as: Before actual vlen handling, fix the riscv_gdbarch_features hashing function based on the actual valid range of vlen. In bytes, vlen is 0, or 4 <= xlen <= 8192. With that done, this commit (2/2) is: Approved-By: Andrew Burgess Thanks, Andrew > To reflect all those values, extra 2 bits should be hashed. > --- > gdb/arch/riscv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/arch/riscv.h b/gdb/arch/riscv.h > index d5ea1a55b214..e1965da69ebb 100644 > --- a/gdb/arch/riscv.h > +++ b/gdb/arch/riscv.h > @@ -90,7 +90,7 @@ struct riscv_gdbarch_features > | (has_fcsr_reg ? 1 : 0) << 13 > | (xlen & 0x1f) << 5 > | (flen & 0x1f) << 0 > - | (vlen & 0xfff) << 14); > + | (vlen & 0x3fff) << 14); > return val; > } > }; > -- > 2.41.0