From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id 571623858C74 for ; Thu, 6 Jul 2023 16:31:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 571623858C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 880D710049590 for ; Thu, 6 Jul 2023 16:31:27 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id HRt9qRwnC82LXHRt9qN1LH; Thu, 06 Jul 2023 16:31:27 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=VNgYI/DX c=1 sm=1 tr=0 ts=64a6ec5f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=ws7JD89P4LkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=HnGmhRLiCiFpt7SUowkA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=q4hNln0lNklHUoi/ksqO3FLUB7zD/t+7u6rx03E7THg=; b=VTw7PHWShfRBerWLWjpuXtaIZm tU65CCZPqpQ3W1fNRLGb/NgIAGKxf/opi+o3Mthqdx7OpqUM54wbudKQQfaTPp24FJZStYOFnyhHC UUC2gD3oDU6s8ZQbW+//2SYea; Received: from 75-166-135-140.hlrn.qwest.net ([75.166.135.140]:50470 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qHRt9-000VLT-0m; Thu, 06 Jul 2023 10:31:27 -0600 From: Tom Tromey To: Felix Willgerodt via Gdb-patches Cc: markus.t.metzger@intel.com, simark@simark.ca, Felix Willgerodt Subject: Re: [PATCH v9 09/10] btrace, python: Enable ptwrite filter registration. References: <20230704123600.5944-1-felix.willgerodt@intel.com> <20230704123600.5944-10-felix.willgerodt@intel.com> X-Attribution: Tom Date: Thu, 06 Jul 2023 10:31:26 -0600 In-Reply-To: <20230704123600.5944-10-felix.willgerodt@intel.com> (Felix Willgerodt via Gdb-patches's message of "Tue, 4 Jul 2023 14:35:59 +0200") Message-ID: <87sfa1t31d.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.135.140 X-Source-L: No X-Exim-ID: 1qHRt9-000VLT-0m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-135-140.hlrn.qwest.net (murgatroyd) [75.166.135.140]:50470 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Felix Willgerodt via Gdb-patches writes: > By default GDB will be printing the hex payload of the ptwrite package as > auxiliary information. To customize this, the user can register a ptwrite > filter function in python, that takes the payload and the PC as arguments and > returns a string which will be printed instead. Registering the filter > function is done using a factory pattern to make per-thread filtering easier. Thank you for the patch. > + /* Function pointer to the ptwrite callback. Returns the string returned > + by the ptwrite filter function. */ > + gdb::optional (*ptw_callback_fun) (const uint64_t payload, > + const uint64_t ip, > + const void *ptw_context) > + = nullptr; > + > + /* Context for the ptw_callback_fun. */ > + void *ptw_context = nullptr; I tend to think it's better to use std::function here, rather than the C-style pointer-and-data approach. > diff --git a/gdb/python/lib/gdb/ptwrite.py b/gdb/python/lib/gdb/ptwrite.py I gather the new stuff is documented in the next patch. > +# _ptwrite_filter contains the per thread copies of the filter function. > +# The keys are tuples of inferior id and thread id. > +# The filter functions are created for each thread by calling the > +# _ptwrite_filter_factory. > +_ptwrite_filter = {} It seems like when an inferior or thread is destroyed, the entries should be removed from this map. > + gdbpy_ref<> py_payload (PyLong_FromUnsignedLongLong (payload)); > + gdbpy_ref<> py_ip (PyLong_FromUnsignedLongLong (ip)); Both of these calls require null checks. > + gdbpy_ref<> py_result (PyObject_CallFunctionObjArgs ((PyObject *) ptw_filter, > + py_payload.get (), > + py_ip.get (), > + nullptr)); > + > + if (PyErr_Occurred ()) It's more idiomatic to check == nullptr than PyErr_Occurred. > + result = gdbpy_obj_to_string (py_result.get ()).get (); > + > + if (PyErr_Occurred ()) Here too. Tom