From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 7B2173855882 for ; Fri, 9 Jun 2023 14:16:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B2173855882 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 9F62410046244 for ; Fri, 9 Jun 2023 14:16:20 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 7cuaqA34UCZpF7cuaqv3yP; Fri, 09 Jun 2023 14:16:20 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=BfAdbph2 c=1 sm=1 tr=0 ts=64833434 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=of4jigFt-DYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6xY+quW0tbMKvqvvyMp10Aljp9jj7JKUIgpSPNQsHNw=; b=rIO+GVCV0Yo+gipn5ziu7n/mpQ vVD+82oQ5ZNW39dSBqGHF23eYVM70x2PxeR+WSUtf8OuapUToeu8FbBpom9/dJRhhyVQO3dVNqgfu ZhhVmqyehJ2U/BNy/sz2pROdT; Received: from 75-166-136-83.hlrn.qwest.net ([75.166.136.83]:42758 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q7cua-001O6m-46; Fri, 09 Jun 2023 08:16:20 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries , Tom Tromey Subject: Re: [PATCH 2/2] [gdb/tui] Delete line buffer when switching to singlekey References: <20230606150333.5206-1-tdevries@suse.de> <20230606150333.5206-2-tdevries@suse.de> X-Attribution: Tom Date: Fri, 09 Jun 2023 08:16:19 -0600 In-Reply-To: <20230606150333.5206-2-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Tue, 6 Jun 2023 17:03:33 +0200") Message-ID: <87sfb090wc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.136.83 X-Source-L: No X-Exim-ID: 1q7cua-001O6m-46 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-136-83.hlrn.qwest.net (murgatroyd) [75.166.136.83]:42758 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> The SingleKey "d" is supposed run the "down" command. Tom> Fix this by clearing the readline line buffer when switching to SingleKey Tom> mode. I was wondering if saving and restoring the partial text would be better, but honestly this is better than the status quo, and it's not clear to me that people switch in and out of SingleKey so much that this kind of detail would matter. So, seems good. Reviewed-By: Tom Tromey Tom