From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 15C13384643C for ; Thu, 18 May 2023 17:22:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 15C13384643C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 5665B100410EE for ; Thu, 18 May 2023 17:22:57 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id zhL7pqg2YZZlczhL7pE3yF; Thu, 18 May 2023 17:22:57 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=F56SyotN c=1 sm=1 tr=0 ts=64665ef1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=y26Bvzfj-3c2TpXgXE0A:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ta+kNEGXnCQbk3q2TZtqkLkZGGE5UnScdmSgZzztypE=; b=Z9hp+ZwkHMww18ysnKawwpZ4J2 4Qij9d2au8Ni7HPOXmXQWIPKXOgA2jtmuQPkP7sy6BjiPWeycedGnxctc/K9tK0T9y4rUAHezG//6 vgPi6KzMzg+21axMN0gCWJ8wy; Received: from 75-166-157-55.hlrn.qwest.net ([75.166.157.55]:58374 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pzhL6-0047HN-RL; Thu, 18 May 2023 11:22:56 -0600 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCH 0/2] New test for find_pc_sect_line References: X-Attribution: Tom Date: Thu, 18 May 2023 11:22:56 -0600 In-Reply-To: (Andrew Burgess via Gdb-patches's message of "Thu, 18 May 2023 09:37:53 +0100") Message-ID: <87sfbtzh8v.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.157.55 X-Source-L: No X-Exim-ID: 1pzhL6-0047HN-RL X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-157-55.hlrn.qwest.net (murgatroyd) [75.166.157.55]:58374 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> Adds a new test to extend coverage of find_pc_sect_line, then adds Andrew> some asserts and safety checks to skip_prologue_using_sal. These both seem fine to me. Reviewed-By: Tom Tromey Tom